331629 - nsAutoCompleteController::ClosePopup 91c5d689

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Alex Vincent [:WeirdAl]]

Stack Signature	 nsAutoCompleteController::ClosePopup 91c5d689
Product ID	Firefox15
Build ID	2006011112
Trigger Time	2006-03-24 12:06:39.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	firefox.exe + (003ff412)
URL visited	
User Comments	
Since Last Crash	282 sec
Total Uptime	122668 sec
Trigger Reason	Access violation
Source File, Line No.	c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp, line 862
Stack Trace 	
nsAutoCompleteController::ClosePopup  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp, line 862]
nsAutoCompleteController::PostSearchCleanup  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp, line 1109]
nsAutoCompleteController::OnSearchResult  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp, line 589]
nsGlobalHistory::StartSearch  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/history/src/nsGlobalHistory.cpp, line 4231]
nsAutoCompleteController::StartSearch  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp, line 901]
nsAutoCompleteController::Notify  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp, line 602]
nsAppStartup::Run  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 151]
main  [c:/builds/tinderbox/Fx-Mozilla1.8.0/WINNT_5.2_Depend/mozilla/browser/app/nsBrowserApp.cpp, line 61]
kernel32.dll + 0x16d4f (0x7c816d4f)

Steps to reproduce:

(1) Firefox 1.5.0.1 for Windows
(2) Modify Venkman (JavaScript Debugger) XPI as listed on addons.mozilla.org to work in Firefox 1.5.
(3) Run Venkman in the background
(4) Find a form with an autocomplete text input
(5) Fill out the form.
(6) Revisit the form and begin re-entering the value in the autocomplete text input you last used.

Expected result:

Autocomplete shows you a suggested entry.

Actual result:

Crash.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: null check

According to TB there are still crashes @nsAutoCompleteController::ClosePopup.
Though the stacktraces have changed. Now it is nsAutoCompleteController::Rollup
which calls ClosePopup when mInput is apparently null. This is in trunk and 1.8.1.
So I propose adding null check for mInput. That check is used also elsewhere in
nsAutoCompleteController.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This should be fixed now.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235895 [details] [diff] [review]
null check

a=beltzner on behalf of 181drivers