331656 - hiddenWindow.xul throws many JS errors

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

When the views were switched over from xul to xbl, hiddenWindow.xul (which prevents the Mac from losing the menubar when you've closed the last window on the screen) never got told about it. :)

As a result, there's a bunch of errors and warnings in the JavaScript Console like :
"Error: no element found: chrome://calendar/content/dayView.xul"
"Warning: Failed to load overlay from chrome://calendar/content/multiweekView.xul. Source File: chrome://calendar/content/hiddenWindow.xul"

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 TRUNK - Removes references to the old xul view overlays

Comment 2

[Joey Minta]

Comment on attachment 216177 [details] [diff] [review]
rev0 TRUNK - Removes references to the old xul view overlays

Thanks for the patch! r=jminta

Note that I'm highly skeptical of our ability to provide true hidden-window support at this stage, due to things like bug 329581.  My concept of how hidden-window works may be incorrect though.

Comment 3

[Matthew (lilmatt) Willis]

patch committed to HEAD and MOZILLA_1_8_BRANCH

Comment 4

[Matthew (lilmatt) Willis]

-> VERIFIED