331706 - Leak when scrolling

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Régis Caspar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060325 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060325 Firefox/1.6a1

When scrolling a page containing a decent amount of text, memory usage grows at each scroll. This seems to be a bug specific to cairo builds.

Reproducible: Always

Steps to Reproduce:
1. Open attached testcase
2. Press start
3. Monitor Firefox memory usage (with Windows's task manager or process explorer)

Actual Results:  
Memory usage grows (see attached picture)

Expected Results:  
No memory usage grows

Attached: 
 - testcase
 - memory usage graph (Process Explorer)

Comment 1

[Régis Caspar]

Attachment: testcase

Comment 2

[Régis Caspar]

Attachment: Mem. usage graph

Graph showing memory usage growth during testcase usage

Comment 3

[Steve England [:stevee]]

I see this with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060325 Firefox/1.6a1 (Cairo)

I do not see this with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060325 Firefox/1.6a1 ID:2006032503 (Non-cairo)

Leak-gauge.pl reports no leakage for the objects it tracks.

Comment 4

[Bengt-Erik Soderstrom]

Yes I see this too, just as you described

Comment 5

[Stuart Parmenter]

I don't think this is a cairo bug.

Comment 6

[Steve England [:stevee]]

So are we talking about a VC6 (pacifica) versus VC8 (gaius) issue then?

Comment 7

[Bengt-Erik Soderstrom]

For the testcase I had the used memory growing well over 100M in my VC8 Express build of today. (with cairo)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

I let the testcase run for a few minutes on my own non cairo-enabled VC8 build and my memory usage jumped no more than 1-1.5MB and went back to where it started at after stopping it and going back.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060324 Firefox/1.6a1 ID:2006032417

Comment 9

[Ryan VanderMeulen [:RyanVM]]

I just did a build off the exact same codebase as my previous post, but with Cairo enabled. I can confirm that memory usage does indeed go up quite rapidly in the testcase while it doesn't with Cairo disabled (like I said previously).

Comment 10

[Régis Caspar]

Attachment: bloatlog before running test

Testcase was slightly modified: 
gTest.timer = window.setTimeout(gTest.scrollAuto, 100, -amount);

on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060328 Firefox/1.6a1 (custom debug build)

Comment 11

[Régis Caspar]

Attachment: bloatlog after running test

Comment 12

[u88484]

Confirmed here also Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060326 Firefox/1.6a1 ID:2006032612

Comment 13

[Stuart Parmenter]

i just checked in a fix that should probably fix it.  reopen if you're still seeing it in tomorrow's builds.

Comment 14

[Steve England [:stevee]]

As a matter of interest, what was the bug responsible for this?

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

I believe it's this checkin:
1.31	pavlov%pavlov.net	2006-03-31 17:45	 	free the cairo glyphs. r=vlad
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=gfxWindowsFonts.cpp&branch=&root=/cvsroot&subdir=mozilla/gfx/thebes/src&command=DIFF_FRAMESET&rev1=1.30&rev2=1.31

Comment 16

[Régis Caspar]

Confirmed fixed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060403 Firefox/1.6a1 ID:2006040312. 
Thanks Stuart for your quickfix fix.