331708 - When importing folders from Eudora, Thunderbird ignores folders whose names begin with a space

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[harveyk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

I just installed Thunderbird and imported everything from Eudora 7.
I have a folder named " To Do" at the top of my list.
I added the space in the name " To Do" so that it is first alphabetically.
Thunderbird ignored this folder and did not import it.
It imported all the rest of my folders...

Reproducible: Didn't try

Steps to Reproduce:
1. Create folder with " " (space) as first character of name in Eudora
2. Install Thunderbird
3. Import folders from Eudora

Actual Results:  
Would have to uninstall and reinstall Thunderbird, and it took forever to import, so I didn't try, Sorry...

Expected Results:  
Folder should have been imported

n/a

Comment 1

[Olle Lindeberg]

I just want to conform the same problem, all folders and mailboxes with a name starting with a space was not imported.
/olle

Comment 3

[Geoffrey C. Wenger]

The problem is that the importing code that scans the descmap.pce erroneously strips leading spaces from the mailbox or folder name. Patch coming soon.

Comment 4

[Geoffrey C. Wenger]

Attachment: Patch that fixes bug. Note patch was not created with CVS.

Code was erroneously stripping spaces from the file name.

Comment 5

[David :Bienvenu]

Comment on attachment 260377 [details] [diff] [review]
Patch that fixes bug. Note patch was not created with CVS.

looks good - I will try land this on the trunk soon, and I'll nominate it for the 1.8.1 branch, for after 2.0

Comment 6

[David :Bienvenu]

landed on the trunk; sorry I forgot about this. Will nominate for 1.8.1 branch now.

Comment 7

[David :Bienvenu]

Comment on attachment 260377 [details] [diff] [review]
Patch that fixes bug. Note patch was not created with CVS.

straightforward fix...

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 260377 [details] [diff] [review]
Patch that fixes bug. Note patch was not created with CVS.

approved for 1.8.1.10, a=dveditz for release-drivers

Comment 9

[David :Bienvenu]

fixed for 1.8.1.10