331739 - Add "Show blocked popup(s)" button to popup blocker message bar

Status: NEW

(Firefox :: Security, enhancement, P3)

Description

[Joe Hughes]

Right now, the UI for the message bar that appears when a popup is blocked is a bit confusing.  The interactive features are (1) a close box (simple enough), and (2) a "Properties" button that unexpectedly yields a menu when clicked.  The menu has options to always allow popups from the current site, to disable the message bar, to actually edit popup blocker properties.  It also (when possible, see bug 264716) has a list of popups that you can click on individually to show.

I propose to change the message bar so that it contains two buttons: "Show blocked  popup(s)", and "Properties...".  The first button has the effect of showing *all* popups that were blocked.  (If a power user wants finer-grained control, they can use the popup blocker widget in the status bar.)  The Properties... button would more traditionally go to the popup blocker properties dialog.  It's true that the "allow popups from this site" menu option is unaccounted-for in this proposed design; we could just leave that functionality to the properties dialog, since it opens pre-populated with the current site, or we could add another button for it to the message bar.

I believe this would simplify the interaction model of the popup blocking message bar, at the cost of some visual cleanliness.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The current browsermessage API is limited to one button, which is why these suck so much. Bug 268590 (doesn't have the best summary but) covers a new browsermessage API, so I suppose this should depend on it.

Comment 2

[Joe Hughes]

Thanks for the pointer; having done some digging earlier today, that's what I was afraid of.  Do you have any useful references on the browsermessage stuff?  I must be blind, because I haven't been able to find where the gBrowser.showMessage() calls are going to in LXR.  I did find the XBL binding where the magic happens, though:
http://lxr.mozilla.org/mozilla1.8/source/toolkit/content/widgets/browser.xml#906
It does indeed lay out a pretty rigid format: [image][text][button][closebox]

Comment 3

[:Gavin Sharp [email: [e-mail]]]

showMessage is http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/tabbrowser.xml#228

Comment 4

[Joe Hughes]

Ah, thanks

Comment 5

[Ria Klaassen (not reading all bugmail)]

*** Bug 332981 has been marked as a duplicate of this bug. ***

Comment 6

[Ria Klaassen (not reading all bugmail)]

*** Bug 356371 has been marked as a duplicate of this bug. ***

Comment 7

[Kevin Pellet (Ilphrin)]

Hi,

I think this bug can be closed, as the way of showing blocked popups has substantially changed in....13 years.