Please don't absolutely require zip to build

RESOLVED WONTFIX

Status

Firefox Build System
General
--
enhancement
RESOLVED WONTFIX
12 years ago
3 months ago

People

(Reporter: glandium, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1

At the moment, even if you build with --enable-chrome-format=flat, you still need zip. It would be nice to not require it.
Patch following.

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Created attachment 216335 [details] [diff] [review]
Patch

The mozilla/security/nss/lib/fortcrypt/swfort/pkcs11/config.mk is maybe to change. I don't know if LIBCI_JAR and LIBCI_SW_JAR are any useful. It is indeed useless for firefox and other applications, but maybe useful for standalone NSS.

If that is, the patch needs to be adapted to add these conditionally.
Attachment #216335 - Flags: review?(benjamin)
(Reporter)

Comment 2

12 years ago
(Making the summary more understandable)
Summary: Don't absolutely require zip to build → Please don't absolutely require zip to build

Comment 3

12 years ago
Comment on attachment 216335 [details] [diff] [review]
Patch

Flat-chrome is a debugging option only and has a significant performance penalty, and I don't feel like optimizing for that case.
Attachment #216335 - Flags: review?(benjamin) → review-

Updated

12 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 4

12 years ago
I fail to see how not having to unzip can have performance penalty O_o

Comment 5

12 years ago
Wrt performance, see bug 118455 & bug 201224.  You can avoid needing a real zip binary (ignoring NSS) by setting 'ZIP=true' in your .mozconfig.

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.