Endianness problem on mipsel in fdlibm

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: glandium, Unassigned)

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
Other
All
fixed1.8.0.4, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.1 +
blocking1.8.0.4 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1

Everything is in the summary.
Patch following.

Reproducible: Always
(Reporter)

Comment 1

11 years ago
Created attachment 216375 [details] [diff] [review]
Patch

Courtesy of Ian Jackson and Thiemo Seufer.
(Reporter)

Updated

11 years ago
Attachment #216375 - Flags: review?(brendan)
Comment on attachment 216375 [details] [diff] [review]
Patch

rs=me, and it looks right to an old SGI'er, but note that we are putting fdlibm out to pasture.  Modern libms are good enough, mostly (some workarounds for NaN mishandling still required).

/be
Attachment #216375 - Flags: review?(brendan) → review+
Trivial porting fix. Checking into trunk and 1.8 branch now.

/be
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.8.1+
Flags: blocking1.8.0.3?
Keywords: fixed1.8.1

Updated

11 years ago
Attachment #216375 - Flags: approval1.8.0.3?
Attachment #216375 - Flags: approval-branch-1.8.1+

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 4

11 years ago
Seems like a no-brainer. My pre-vote for release team is to plus it!
Flags: blocking1.8.0.3? → blocking1.8.0.3+
Comment on attachment 216375 [details] [diff] [review]
Patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #216375 - Flags: approval1.8.0.3? → approval1.8.0.3+

Updated

11 years ago
Flags: in-testsuite-
Fixed on the 1.8.0 branch.

/be
Keywords: fixed1.8.0.3
You need to log in before you can comment on or make changes to this bug.