331905 - copying folder puts the bookmarks in the target

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dave Townsend [:mossop]]

If I drag a folder in the places organiser and hold ctrl to copy it to the target, an empty folder of the right name appears at the target, and all the bookmarks in the source folder appear in the target folder, not in the newly created folder in the target as expected.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

happens for all copies, drag or not. accessibility bug too. 

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Patch does: 
- makes sure the delete context menu item shows up on host folders (oops!)
- renames PlacesInsertSeparatorTransaction to PlacesCreateSeparatorTransaction just like all the other Create transactions
- reworks getFolderCopyTransaction significantly. This is for folder copies. The new one works like this:

When a folder is copied and pasted, it creates a clone of the folder hierarchy underneath it elsewhere in the bookmarks structure. The child content needs to be copied into the right places in the new structure. This means that the PlacesCreateItemTransactions that create the new URLs don't know at the time they are created what folder they're going into, because that folder hasn't been created yet! We need to be able to tell them later where they should be inserted. We do this by making the former private ._container property public, in .container. 

Then we change _getFolderCopyTransaction to return a PlacesCreateFolderTransaction for the root folder, and attach to it the result of a depth-first walk of the folder's children. 

Later, when PlacesCreateFolderTransaction's doTransaction method is called, it creates the folder then walks the child list and executes those transactions, creating child items, separators and subfolders.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Puts getRemoveFolderTransaction into the PlacesRemoveFolderTransaction ctor itself, rather than making the caller call it explicitly.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

fixed branch and trunk

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381