331913 - Highlighted text for a scrolling Find is below viewport when popup blocker bar is open

Status: RESOLVED FIXED

(Camino Graveyard :: Page Layout, defect, P3)

Description

[Dan Stillman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060327 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060327 Camino/1.2+

The Find function doesn't take the height of the new popup blocker bar into account when calculating the coordinates of text. Since it normally scrolls to just below the line containing the text, it is 60 or so pixels below the viewport if the popup bar is open.

Reproducible: Always

Steps to Reproduce:
1. Open a page with a pop-up up that gets blocked. (The tests on http://popuptest.com will work but you'll need to shrink your browser window vertically so that the one line of text is out of view.)
2. Without closing the pop-up bar, scroll down and choose some text below the fold to search for, and then scroll back up so that it is out of the viewable area.
3. Bring up Find and search for the text.
Actual Results:  
The highlighted (i.e. found) text is out of view, directly below the bottom of the viewport.

Expected Results:  
The highlighted text should be within the viewable area.

Comment 1

[Samuel Sidler (old account; do not CC)]

Probably related to / the same cause as bug 331430.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

There's also a bug where this happens without the popup blocker, iirc (we don't scroll so the term is in view always, or something like that).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is the other regression from the new pop-up notification bar.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Does camino put this popup bar into the page itself?

Comment 5

[Chris Lawson (gone)]

(In reply to comment #2)
> There's also a bug where this happens without the popup blocker, iirc (we don't
> scroll so the term is in view always, or something like that).
 
I think you're thinking of the bug where we don't scroll *enough* in the filer's opinion. Instead, we only scroll just enough so that it's at the very bottom of the page.

Comment 6

[Håkan Waara]

(In reply to comment #4)
> Does camino put this popup bar into the page itself?

Yeah I think we have the browser content view and view the scrollbar's in as siblings, so one pushes the other down because we don't readjust the sizes. :(

Is that right, Mike?

Comment 7

[Håkan Waara]

I mean to say:   I think the view the scrollbar is in and the popup blocker view are "siblings", so one push the other down.

Comment 8

[Håkan Waara]

Fix is in bug 331430

Comment 9

[Håkan Waara]

Checked in on trunk & branch.