331925 - Unable to use pronouns (%user%, %reporter%, ...) in boolean charts when searching for the flag requestee or the flag setter

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

I'm unable to use the %user% pronoun when searching for a flag requestee or flag setter.  I thought this would be an easy fix, something like below.  However, I don't know how the "$1" gets set when calculating the pronoun id value.

--- Bugzilla/Search.pm	2005-12-01 17:54:39.000000000 -0800
+++ Bugzilla/Search.pm	2006-03-27 18:03:27.000000000 -0800
@@ -834,6 +834,13 @@
                                "ON $flags.requestee_id = requestees_$chartid.userid");
              $f = "requestees_$chartid.login_name";
          },
+         "^setters.login_name,(?:equals|anyexact),(%\\w+%)" => sub {
+             my $flags = "flags_$chartid";
+             push(@supptables, "LEFT JOIN flags AS $flags " .
+                               "ON bugs.bug_id = $flags.bug_id " .
+                               "AND $flags.is_active = 1");
+             $term = "$flags.setter_id = " . pronoun($1,$user);
+         },
          "^setters.login_name," => sub {
              my $flags = "flags_$chartid";
              push(@supptables, "LEFT JOIN flags AS $flags " .
   

Reproducible: Always

Steps to Reproduce:

Comment 1

[timeless]

this hit me, and it's very annoying.

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> this hit me, and it's very annoying.

I'm attempting to setup a saved query for whining for the AMO team and flag_requestee goes unnoticed the most.  So... +1.

Comment 4

[Reed Loden [:reed]]

(In reply to comment #0)
> However, I don't know how the "$1" gets set when calculating the pronoun id
> value.

The $1 is the result of the regex grouping "(%\\w+%)", which would be "%blah%".

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v1 (untested)

Here's an untested port of the patch in comment #0 to current tip.

Comment 6

[Reed Loden [:reed]]

I have this up on https://landfill.bugzilla.org/331925/ for testing. My test link is https://landfill.bugzilla.org/331925/buglist.cgi?query_format=advanced&field0-0-0=setters.login_name&type0-0-0=equals&value0-0-0=%25user%25, but it isn't working. Any assistance would be appreciated!

Comment 8

[Frédéric Buclin]

Attachment: patch, v2

Must be applied on top of bug 574577.

Comment 9

[Frédéric Buclin]

And before mkanat asks, yes, all xt tests pass. :) But I'm a bit disappointed that this doesn't fix some TODO tests. :( Does it mean xt tests didn't add such tests in the TODO list?

Comment 10

[David Lawrence [:dkl]]

Comment on attachment 580449 [details] [diff] [review]
patch, v2

Review of attachment 580449 [details] [diff] [review]:
-----------------------------------------------------------------

Works as expected. r=dkl

Comment 11

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Search.pm
Committed revision 8120.

Comment 12

[Max Kanat-Alexander]

(In reply to Frédéric Buclin from comment #9)
> And before mkanat asks, yes, all xt tests pass. :) But I'm a bit
> disappointed that this doesn't fix some TODO tests. :( Does it mean xt tests
> didn't add such tests in the TODO list?

  Yeah, xt isn't testing the pronouns. It really ought to be; that would be a worthwhile xt enhancement.

Comment 13

[Frédéric Buclin]

Added to relnotes for 4.4.