331961 - Partial submission "required check" is wrong

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

There is an error in the required checking in the submission handling. It checks for requiredness of the @ref'ed node AND its siblings. This happens both in CanSubmit() and CopyChildren(), so this is wrong for all types of submissions.

Comment 1

[Allan Beaufour]

Attachment: Testcase

Comment 2

[Allan Beaufour]

Attachment: Patch

Fix by not checking siblings on first run of CopyChildren() and CanSubmit() (by respectively using depth and adding parameter).

I also fixes the GetModel() issue mentioned in bug 326452.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 216520 [details] [diff] [review]
Patch


>+  NS_HIDDEN_(nsresult) CopyChildren(nsIModelElementPrivate* model, nsIDOMNode *source, nsIDOMNode *dest, nsIDOMDocument *destDoc, SubmissionAttachmentArray *, const nsString &cdataElements, PRBool indent, PRUint32 depth);


Way too long line. Fix that, r=me

Comment 4

[Allan Beaufour]

(In reply to comment #3)
> (From update of attachment 216520 [details] [diff] [review] [edit])
> 
> >+  NS_HIDDEN_(nsresult) CopyChildren(nsIModelElementPrivate* model, nsIDOMNode *source, nsIDOMNode *dest, nsIDOMDocument *destDoc, SubmissionAttachmentArray *, const nsString &cdataElements, PRBool indent, PRUint32 depth);
> 
> 
> Way too long line. Fix that, r=me

Please do check the rest of that file... they are all like that :( Not that I like, but then all of them should be fixed.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #4) 
> Please do check the rest of that file... they are all like that :( Not that I
> like, but then all of them should be fixed.
> 

Well, why don't you fix them ;)

Comment 6

[Allan Beaufour]

(In reply to comment #5)
> (In reply to comment #4) 
> > Please do check the rest of that file... they are all like that :( Not that I
> > like, but then all of them should be fixed.
> > 
> 
> Well, why don't you fix them ;)

/me throws a tortilla after smaug

Comment 7

[Allan Beaufour]

Checked into trunk