Closed Bug 332037 Opened 14 years ago Closed 14 years ago

Make Sunbird built with MOZ_DEBUG=1 be more obvious

Categories

(Calendar :: General, defect, trivial)

Sunbird 0.3a1
PowerPC
macOS
defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(1 file, 1 obsolete file)

A Sunbird built with MOZ_DEBUG=1 looks no different than one without. It would be good to make it more obvious that debug is enabled. Ff and Tb both do this.
dmose thought this wasn't a bad idea.
Attachment #216582 - Flags: first-review?(jminta)
Comment on attachment 216582 [details] [diff] [review]
rev0 - changes app name to "SunbirdDebug" for builds with debug enabled

I'm not qualified to review makefile stuff, over to mvl.
Attachment #216582 - Flags: first-review?(jminta) → first-review?(mvl)
I was trying to make too many changes to this Makefile at once but keep the patches relevant to only one bug, and I forgot the sed line.
Attachment #216582 - Attachment is obsolete: true
Attachment #216585 - Flags: first-review?
Attachment #216582 - Flags: first-review?(mvl)
Attachment #216585 - Flags: first-review? → first-review?(mvl)
Comment on attachment 216585 [details] [diff] [review]
rev1 - forgot this part 

This part looks good, but it seems that you missed changing Info.plist.in to actually contain APP_NAME instead of the hard-coded Sunbird. Otherwise i don't see the use of the sed.
Attachment #216585 - Flags: first-review?(mvl) → first-review+
(In reply to comment #4)
> (From update of attachment 216585 [details] [diff] [review] [edit])
> This part looks good, but it seems that you missed changing Info.plist.in to
> actually contain APP_NAME instead of the hard-coded Sunbird.

You're right. I missed diffing Info.plist.in when I made the patch.

rev1 checked in with that change to trunk and 1.8
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
-> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.