33208 - Editor fails to initialize on pages with JS

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Akkana Peck]

Run mozilla -edit http://www.shallowsky.com/moon/hitchhiker.html
Do File->Quit
On linux, I see a JS error, which turns out to be because EditorGetDocument()
fails because the editor never got initialized.  I'm working on tracking it down
further and find out why the editor doesn't get initialized.

Charley says he sees a crash on windows, apparently going through
s_ReportUncaughtException (which on Unix just prints out the error message).

Comment 1

[Charles Manske]

The editor seemed to be initialized when I tested this morning.
Please attach a test file so we're all "on the same page."

Comment 2

[Akkana Peck]

Charley: see the URL and instructions I already added to this bug.

I've tracked it down further: the GetStyleContextFor call inside
nsEditor::IsPreformatted (when doing ReplaceNewlines while initializing the
plaintext rules) is failing.

Comment 3

[Akkana Peck]

Okay, here's the deal.  JS code inside the body shows up as text nodes, and it
has no style context.  So we can't depend on every node having a style context. 
We can either treat those nodes as pre, or as non-pre, but in either case, we
should not return an error from IsPreFormatted, just true or false.  In my tree,
I have it set to return false (i.e. these nodes are not preformatted), and now
the page initializes just fine and I can edit it.

Will check in the fix along with the disable-JS changes, when they're reviewed. 
Will attach the diff for this part to this bug -- can you review it, and see if
it fixes your crash?

Comment 4

[Akkana Peck]

Attachment: Patch to fix the problem

Comment 5

[Akkana Peck]

Fixed.

Comment 6

[sujay]

verified in 3/30 build.