332241 - Resurrect jsdb

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[timeless]

jsdb is a commandline based debugger, and it's a lot easier to use it to chase down problems in jsd than to deal w/ venkman or eclipse or visual javascript.

(there are problems in jsd, especially leaked roots.)

Comment 1

[timeless]

Attachment: fix build and add support for request model

Comment 2

[:Gijs (he/him)]

Comment on attachment 216756 [details] [diff] [review]
fix build and add support for request model

>Index: jsdb.c
>===================================================================
>RCS file: /cvsroot/mozilla/js/jsd/jsdb/jsdb.c,v
>retrieving revision 1.6
>diff -uwp -r1.6 jsdb.c
>--- jsdb.c
>+++ jsdb.c
>@@ -43,6 +43,11 @@
> #include "jsdbpriv.h"
> #include <errno.h>
> 
>+#ifndef JS_THREADSAFE
>+#define JS_BeginRequest(cx) (void)0
>+#define JS_EndRequest(cx) (void)0
>+#endif
>+
> /***************************************************************************/
> 
> JS_STATIC_DLL_CALLBACK(void)


Everything fine except the above thing. Are there really no better solutions here?

r=gijs, assuming you can explain me why the above is there. :-)

Finally, I would say that I'm not the best person to review this - but apparently just about the only one at the moment.

Comment 3

[timeless]

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/js/src/jsapi.h&rev=3.162&mark=433,435-439,484#430

there's simply no other guard. i could do i slightly differently, but basically JS either has the methods if you have the define, or it doesn't.

Comment 4

[timeless]

Comment on attachment 216756 [details] [diff] [review]
fix build and add support for request model

mozilla/js/jsd/jsdb/Makefile.in 	1.5
mozilla/js/jsd/jsdb/jsdb.c 	1.7

Comment 5

[Reed Loden [:reed]]

Backed out as part of the find-the-Tp-regression game we're currently undertaking.

Comment 6

[timeless]

Comment on attachment 216756 [details] [diff] [review]
fix build and add support for request model

mozilla/js/jsd/jsdb/Makefile.in 	1.7
mozilla/js/jsd/jsdb/jsdb.c 	1.9

for the record: that was uncalled for, the patch was to a directory that did not build.