Closed Bug 332283 Opened 14 years ago Closed 13 years ago

No drag and drop feedback in places trees anymore


(Firefox :: Bookmarks & History, defect, P2)




Firefox 3 alpha7


(Reporter: bugs, Assigned: enndeakin)



(Whiteboard: [Fx2-parity])


(1 file)

The line drawing between places trees doesn't work anymore for some reason when you drag over trees.
Not sure if this is FE. This may have broken when the view changes landed. Did the drop marker lines show up on the tree when you dragged leaf items around, brett?
Assignee: bugs → brettw
I'm not sure. I just tested it and it works fine for me on branch, but not on trunk. My branch build is a couple of days old, though. Maybe somebody broke the tree control on trunk?
Priority: -- → P3
Target Milestone: Firefox 2 alpha2 → Firefox 2 beta1
*** Bug 327648 has been marked as a duplicate of this bug. ***
*** Bug 337686 has been marked as a duplicate of this bug. ***
Target Milestone: Firefox 2 beta1 → Firefox 3 alpha2
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060828 Minefield/3.0a1 - Build ID: 2006082804. Still broken.
Assignee: brettw → nobody
this is still present on Windows and Mac trunk builds from 05/22/07.  Should probably be higher than a P3; leaving that up to the devs to determine.
i'd argue we want this soon, so that we can do proper testing of dnd.
Priority: P3 → P2
Whiteboard: [Fx2-parity]
Target Milestone: Firefox 3 alpha2 → ---
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Target Milestone: --- → Firefox 3 beta1
Does it happen if you renable the disabled code in nsBaseAppShell::NativeEventCallback? Is so, it's the same cause as bug 337761 and a regression from the thread manager rewrite.

Neil, it still happens even if I re-enable the disabled code in nsBaseAppShell::NativeEventCallback().

Note, there is dnd feedback in the bookmarks sidebar, and the left hand pane in the bookmark organizer, just not the right hand pane of the bookmark organizer.
Add offset when painting drop feedback
Assignee: nobody → enndeakin
Attachment #266615 - Flags: superreview?(roc)
Attachment #266615 - Flags: review?(roc)
Attachment #266615 - Flags: superreview?(roc)
Attachment #266615 - Flags: superreview+
Attachment #266615 - Flags: review?(roc)
Attachment #266615 - Flags: review+
Closed: 13 years ago
Resolution: --- → FIXED
verified (but I'll leave the official verification after I try mac.)

I've updated and rebuilt on windows, and I have the drop feedback again.  

thanks neil, you rule!
I verified this on Mac in build Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200708020808 Minefield/3.0a7pre.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.