332283 - No drag and drop feedback in places trees anymore

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The line drawing between places trees doesn't work anymore for some reason when you drag over trees.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Not sure if this is FE. This may have broken when the view changes landed. Did the drop marker lines show up on the tree when you dragged leaf items around, brett?

Comment 2

[Brett Wilson]

I'm not sure. I just tested it and it works fine for me on branch, but not on trunk. My branch build is a couple of days old, though. Maybe somebody broke the tree control on trunk?

Comment 3

[Brett Wilson]

*** Bug 327648 has been marked as a duplicate of this bug. ***

Comment 4

[Brett Wilson]

*** Bug 337686 has been marked as a duplicate of this bug. ***

Comment 5

[Ed Hume]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060828 Minefield/3.0a1 - Build ID: 2006082804. Still broken.

Comment 6

[Tracy Walker [:tracy]]

this is still present on Windows and Mac trunk builds from 05/22/07.  Should probably be higher than a P3; leaving that up to the devs to determine.

Comment 7

[(not reading, please use [e-mail] instead)]

i'd argue we want this soon, so that we can do proper testing of dnd.

Comment 9

[(not reading, please use [e-mail] instead)]

neil, any ideas?

Comment 10

[Neil Deakin (away Dec 12 - Dec 20)]

Does it happen if you renable the disabled code in nsBaseAppShell::NativeEventCallback? Is so, it's the same cause as bug 337761 and a regression from the thread manager rewrite.

Comment 11

[(not reading, please use [e-mail] instead)]

Neil, it still happens even if I re-enable the disabled code in nsBaseAppShell::NativeEventCallback().

Note, there is dnd feedback in the bookmarks sidebar, and the left hand pane in the bookmark organizer, just not the right hand pane of the bookmark organizer.

Comment 12

[Neil Deakin (away Dec 12 - Dec 20)]

Attachment: another paint order regression

Add offset when painting drop feedback

Comment 13

[(not reading, please use [e-mail] instead)]

verified (but I'll leave the official verification after I try mac.)

I've updated and rebuilt on windows, and I have the drop feedback again.  

thanks neil, you rule!

Comment 14

[Al Billings [:abillings - ex-MoCo]]

I verified this on Mac in build Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200708020808 Minefield/3.0a7pre.

Comment 15

[Gervase Markham [:gerv] (not reading bugmail)]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv