332327 - improve navigation through the rest run log file

Status: RESOLVED FIXED

(NSS :: Test, defect, P2)

Description

[Alexei Volkov]

Log files start to be very big. It is really a pain to find the failure point of a particular test. 

Some changes should be made to all.sh and init.sh to put html tags into the log file so that we navigate using features of html, not a browser scrolling capabilities.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I personally use the browser's text searching facility, not its scroll bar.

Comment 2

[Alexei Volkov]

Attachment: an example

Comment 3

[Alexei Volkov]

Could you please check if you can improve my patch, especially for tinderbox? 

Comment 4

[Slavomir Katuscak]

Hi Alexei,

I checked your patch and I found some problems:
1. There is no header of html page, so it's probably not usable as normal html file.
2. When there is no <pre> tag, everything is on one line and it's hard to read.
3. Log itself contains other html files used for testing (including </pre> and </html> tags), that can cause many formating problems.
4. Tinderbox converts < character to &lt; (on web side), so it's not usable there.

Comment 5

[Slavomir Katuscak]

Example of Tinderbox log with this patch:
http://tinderbox.mozilla.org/showlog.cgi?log=NSS/1171385280.1171386408.22251.gz&fulltext=1

Comment 6

[Slavomir Katuscak]

My suggestion is not to change format to HTML. Idea of tags is good, but I think just simple text tags should be enough, you can use Find function of your web browser.

Comment 7

[Slavomir Katuscak]

Alexei,

I plan to review all testing scripts and fix them to achieve:
1. all tests will report PASSED/FAILED status
2. all tests will have unique names (bug 347112)

So you will be able to search just for 'FAILED' string or for test name. Will there be enough for you, or you would also need to have tags ? (Tags are redundant to test names).

Comment 8

[Alexei Volkov]

It is not enough because sometimes we search for output of the test with specific name. I think just adding <a name="#Test_Name"> before or after each test output will be quite enough. You can also add <a name="#Test_Name" status=PASS> for example.

Comment 9

[Alexei Volkov]

Never mind. We are already marking beginning of each test. I think what you propose will be enough.

Comment 10

[Slavomir Katuscak]

Increasing priority to P2 (based on priorities set on meeting with Nelson in
September).

Comment 11

[Slavomir Katuscak]

Attachment: Patch.

Modified html_* commands to use message IDs. IDs in results.html matches IDs in output.log. There is one thing which is not very nice, using temp file to store ID, because otherwise its value would be lost more times. Let me know if you have better idea how to do it.

Also I modified html_* function to add <TR><TD> tags directly there instead of adding it on many place in code.

Comment 12

[Alexei Volkov]

Comment on attachment 292778 [details] [diff] [review]
Patch.

I also expect test IDs to appear in the tinderbox busted test list.

Comment 13

[Slavomir Katuscak]

Checking in cert/cert.sh;
/cvsroot/mozilla/security/nss/tests/cert/cert.sh,v  <--  cert.sh
new revision: 1.49; previous revision: 1.48
done
Checking in common/init.sh;
/cvsroot/mozilla/security/nss/tests/common/init.sh,v  <--  init.sh
new revision: 1.59; previous revision: 1.58
done
Checking in dbtests/dbtests.sh;
/cvsroot/mozilla/security/nss/tests/dbtests/dbtests.sh,v  <--  dbtests.sh
new revision: 1.14; previous revision: 1.13
done
Checking in iopr/cert_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/cert_iopr.sh,v  <--  cert_iopr.sh
new revision: 1.5; previous revision: 1.4
done
Checking in iopr/ocsp_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/ocsp_iopr.sh,v  <--  ocsp_iopr.sh
new revision: 1.6; previous revision: 1.5
done
Checking in iopr/ssl_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/ssl_iopr.sh,v  <--  ssl_iopr.sh
new revision: 1.4; previous revision: 1.3
done
Checking in pkits/pkits.sh;
/cvsroot/mozilla/security/nss/tests/pkits/pkits.sh,v  <--  pkits.sh
new revision: 1.17; previous revision: 1.16
done
Checking in ssl/ssl.sh;
/cvsroot/mozilla/security/nss/tests/ssl/ssl.sh,v  <--  ssl.sh
new revision: 1.87; previous revision: 1.86
done