33243 - Every text frame addrefs the blink timer

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Simon Fraser [no longer active]]

Every time a text frame is constructed, it addrefs the blink timer (see 
nsTextFrame.cpp). This seems unnecessary. The following diff will fix this.

Comment 1

[buster]

simon: is this assinged to troy because you want troy to do the code review?

Comment 2

[Simon Fraser [no longer active]]

Attachment: Patch to nsTextFrame to only addref the blink timer when necessary

Comment 3

[Simon Fraser [no longer active]]

If either of you guys gives me code review, I'd be happy to check in. In that 
case, assign the bug back to me.

Comment 4

[troy]

Seems like a good thing to fix and the change looks fine to me so go ahead and 
check it in

Comment 5

[Simon Fraser [no longer active]]

Cool, thanks. Will check in when the tree goes green.

Comment 6

[Simon Fraser [no longer active]]

Fix checked in.

Comment 7

[Chris Petersen]

Marking verified per last comments.