Every text frame addrefs the blink timer

VERIFIED FIXED in M15

Status

()

Core
Layout
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

Trunk
All
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
Every time a text frame is constructed, it addrefs the blink timer (see 
nsTextFrame.cpp). This seems unnecessary. The following diff will fix this.

Comment 1

18 years ago
simon: is this assinged to troy because you want troy to do the code review?
(Assignee)

Comment 2

18 years ago
Created attachment 6909 [details] [diff] [review]
Patch to nsTextFrame to only addref the blink timer when necessary
(Assignee)

Comment 3

18 years ago
If either of you guys gives me code review, I'd be happy to check in. In that 
case, assign the bug back to me.

Comment 4

18 years ago
Seems like a good thing to fix and the change looks fine to me so go ahead and 
check it in
Assignee: troy → sfraser
(Assignee)

Comment 5

18 years ago
Cool, thanks. Will check in when the tree goes green.
Status: NEW → ASSIGNED
(Assignee)

Comment 6

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → M15

Comment 7

18 years ago
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.