Propose to add a new function to delete certificate

RESOLVED FIXED

Status

JSS
Library
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Thomas Kwan, Assigned: glen beasley)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

12 years ago
Currently JSS has a function called PK11Store.deleteCert which delete the specified certificate and its key. We need to have a function to just delete certificate. We want to add

PK11Store.deleteCertOnly
(Reporter)

Comment 1

12 years ago
Created attachment 217070 [details] [diff] [review]
New function PK11Store.deleteCertOnly
Attachment #217070 - Flags: review?(glen.beasley)
(Assignee)

Comment 2

12 years ago
Comment on attachment 217070 [details] [diff] [review]
New function PK11Store.deleteCertOnly

looks good. Could you add a little javadoc to PK11Store.java for the the two methods:
for deleleCert state that is also deletes the key, and for deleteCertOnly state it only delete the cert.
Attachment #217070 - Flags: review?(glen.beasley) → review+
(Reporter)

Comment 3

12 years ago
Created attachment 217087 [details] [diff] [review]
New patch with comments

Glen, thanks for the quick turn around.
Attachment #217070 - Attachment is obsolete: true
(Reporter)

Comment 4

12 years ago
Checked in to the trunk

Checking in lib/jss.def;
/cvsroot/mozilla/security/jss/lib/jss.def,v  <--  jss.def
new revision: 1.36; previous revision: 1.35
done
Checking in org/mozilla/jss/pkcs11/PK11Store.c;
/cvsroot/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11Store.c,v  <--  PK11Store.c
new revision: 1.16; previous revision: 1.15
done
Checking in org/mozilla/jss/pkcs11/PK11Store.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11Store.java,v  <--  PK11Store.java
new revision: 1.7; previous revision: 1.6
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.