332689 - js.mak clean targets fail to clean up pch's

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

steps to reproduce:

1. get source
cvs -d:pserver:[e-mail]:/cvsroot co mozilla/js/src

2. visit sandbox
cd mozilla\js\src

3. clear sandbox
rd /s /q Release

4. build
nmake -f js.mak CFG="jsshell - Win32 Release"

5. clean
nmake -f js.mak CFG="jsshell - Win32 Release" clean
nmake -f js.mak CFG="js - Win32 Release" clean
nmake -f js.mak CFG="jskwgen - Win32 Release" clean
nmake -f js.mak CFG="fdlibm - Win32 Release" clean

6. verify
dir Release

Expected Results:
empty directory or no directory

Actual Results:
fdlibm.pch
js.pch
jskwgen.pch
jsshell.pch

notes to QA for verification, the steps should be tested for both Release and Debug (a global replace of Release with Debug in the steps above should work nicely).
--
also:
jsautokw.h (this is my fault, and the real reason i'm filing this bug) and should be cleaned up by the js target since that's what creates it.

--
normally you only need 1 clean target per build target, the fact that you actually have to run N clean targets seems wrong to me, i'd expect js clean to cascade to fdlibm+jskwgen clean and jsshell clean to cascade to js clean. that should probably also be fixed unless there's some special reason not to do that.

Comment 1

[timeless]

Attachment: fix most of nmake clean

vc70.idb and vc70.pdb still appear. i think they're both debug fdlibm files, but i'm not going to figure that out now.

Comment 2

[timeless]

Comment on attachment 217159 [details] [diff] [review]
fix most of nmake clean

mozilla/js/src/js.mak 	3.11

vc70.pdb/vc70.idb are still unhandled and can be addressed by anyone else in another bug at a later date.