332771 - delayed S/Mime verification broken when message opened in separate window

Status: RESOLVED FIXED

(Thunderbird :: Security, defect)

Description

[Niels Endres]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; InfoPath.1)
Build Identifier: version 1.5 (20051201)

Popup displays with message "The displayed message has been digitally signed, but not all its attachments have been downloaded yet. Therefore, the signature cannot be validated. Click OK to download the complete message and validate the signature."

Clicking OK does nothing (the dialogue box disappears, and the signature remains unverified.

Reproducible: Always

Steps to Reproduce:
1. Send large attachment (ie. 20KB excel document) in signed message.

Actual Results:  
Signature is not verified.  Dialogue box appears but does nothing.

Expected Results:  
Dialogue box should do what it states- ie. download the entire message and verify the signature.

Related to bug ID 139460

Comment 1

[Niels Endres]

Same behaviour in version 3 alpha 1 (20060404)

Comment 2

[Frank Wein [:mcsmurf]]

Do you see a error in the JavaScript Console (it should be under Tools->Web Development) when looking at such a message?

Comment 3

[Niels Endres]

Yes.

Error: ReloadWithAllParts is not defined
Source File: chrome://messenger-smime/content/msgReadSMIMEOverlay.js
Line: 71

Comment 4

[Frank Wein [:mcsmurf]]

Do you look at messages within the normal window layout (so on the left side your accounts, on the right upper side the messages overview and on the right down side the message display area)? If not, what window layout do you use?

Comment 5

[Niels Endres]

I have the preview pane disabled.  When I re-enable the preview pane, and check the signature from the preview pane, it works as expected.  When the preview pane is enabled, and I open the message in a new window, and check the signature from there it does not work.

It seems to be a problem only when the message is being displayed in a new window.

Comment 6

[Frank Wein [:mcsmurf]]

Ok, more or less depends then on the Mozilla/SeaMonkey version of this bug. Why not use the normal preview pane so? ;)

Comment 7

[Ralf Hauser]

I have an even more strange, but probably related experience in Bug 377944 comment 4

Comment 8

[Kai Engert (:KaiE:)]

I can confirm this bug.

We use function ReloadWithAllParts for validating the full message, but it is only defined in msgMail3PaneWindow, and not in the separate message window.

Function ReloadWithAllParts() is just a wrapper for a single other function call:

function ReloadWithAllParts()
{
  gDBView.reloadMessageWithAllParts();
}

Comment 9

[Scott MacGregor]

Hmm if that's the case, this bug has been around for a long time. 1.7, 1.8 and the trunk all have ReloadWithAllParts defined only in msgMail3PaneWindow.js.

Comment 10

[Kai Engert (:KaiE:)]

Attachment: Patch v1

In this patch I replaced the call to ReloadWithAllParts() and made it call gDBView.reloadMessageWithAllParts() directly.

I tested this patch using:
- thunderbird 1.8 branch
- seamonkey 1.8 branch
- seamonkey trunk

and I tested in both the default view and the "separate message window" view.

In all 6 combinations it worked as expected, and clicking the ? icon triggered to reload the message and resulted in the "valid signature" icon.


Scott, could you please review?

(Is calling directly ok, or would you prefer that we introduced a new wrapper function that is globally available?)

Thanks

Comment 11

[Scott MacGregor]

Comment on attachment 262646 [details] [diff] [review]
Patch v1

Thanks Kai. Should we remove the method ReloadWithAllParts as well since no one uses that after this change?

Comment 12

[Kai Engert (:KaiE:)]

Attachment: Patch v2

Scott, good point. This new patch removes the obsolete function from mozilla/mailnews and mozilla/mail. Patch applies fine to both trunk and 1.8 branch.

Comment 13

[Scott MacGregor]

Comment on attachment 262648 [details] [diff] [review]
Patch v2

cool!

Comment 14

[Kai Engert (:KaiE:)]

Bug fixed on trunk.

Comment 15

[Kai Engert (:KaiE:)]

Comment on attachment 262648 [details] [diff] [review]
Patch v2

I agree this bug is broken in older versions, too.

I can confirm it's broken in 1.8.

Should we get this patch into both 1.8 and 1.8.0 ?

(Help welcome to verify the bug is in 1.8.0 / Thunderbird 1.5.x)

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 262648 [details] [diff] [review]
Patch v2

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers

Comment 17

[Kai Engert (:KaiE:)]

Checked in to MOZILLA_1_8_BRANCH for 1.8.1.4

Comment 18

[Kai Engert (:KaiE:)]

Checked in to MOZILLA_1_8_0_BRANCH for 1.8.0.12

Comment 19

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 and 1.8.0.12 using:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4pre) Gecko/20070524 Thunderbird/2.0.0.4pre Mnenhy/0.7.5.0 ID:2007052803

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.12pre) Gecko/20070430 Thunderbird/1.5.0.12pre ID:2007043008

Using the STR from comment #0. The S/Mime Verification was not broken and is working as expected. Adding the verified keywords