332785 - [Mac] Use bundle name instead of (empty) filename for helper apps

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Phil Ringnalda (:philor)]

Once we get a getBundleName from bug 332784, View & Edit Actions needs to use it for helper app names #ifdef XP_MACOSX, instead of displaying "Open with ".

Comment 1

[Phil Ringnalda (:philor)]

Fixed in bug 337474

Comment 2

[Phil Ringnalda (:philor)]

Gah, what was I thinking, deciding it was fixed for my problem without actually testing, or looking at which copies of that copied-around code were and weren't getting changed?

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Trunk patch

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 235357 [details] [diff] [review]
Trunk patch

Oops, if you're going to copy code, you should copy the right code.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Trunk patch, v.2

Right, this is the version I meant to copy.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 235364 [details] [diff] [review]
Trunk patch, v.2

r=mano

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Branch patch

Same thing, just with the MOZILLA_1_8_BRANCH interface name.

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Testcase

To test: open the testcase, in the "open or save" dialog choose to open with any app bundle text editor, like TextEdit.app (the testcase is just a couple of words, served as application/hard-cheese), and tick the box to "always do this." In a build without this patch, when you then go to Preferences, Content, File Types, Manage..., the dialog will have an entry that reads "| CHEESE | CHEESE file | Open with |" because we try to use a file name, and the "file" TextEdit.app is actually a directory. With the patch, it will say "| Open with TextEdit |".

Comment 9

[Phil Ringnalda (:philor)]

Drivers: risk is near zero: this is copied from the code that has been displaying feed reader applications since the end of June, and the code around the copied block was copied from this code, so it's prodigal code coming home. Right now we're utterly broken, showing "Open with " for anything the user has chosen as a helper app, and because of the way Mac plugins mostly don't register filename extensions and we hide plugins that don't register extensions, there's nothing much but what the user has chosen shown, so there's only the broken things that could possibly be broken.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235371 [details] [diff] [review]
Branch patch

a=beltzner on behalf of the 181drivers

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/preferences/downloadactions.js 	1.12
mozilla/browser/components/preferences/downloadactions.js 	1.5.2.6