332797 - Erroneous tree.columns[0] undefined property warning

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

Although tree.columns[0] correctly returns the leftmost column a undefined property strict JavaScript warning is logged in the JavaScript console.

Comment 1

[Andrew Miller]

This happens because nsGenericArraySH::NewResolve does this:

if (!JS_GetProperty(cx, obj, "length", &lenval)) {
         return NS_ERROR_UNEXPECTED;
}

but the property is called count and not length.

Comment 2

[Andrew Miller]

I now have a patch for this, which makes a new attribute, length, which is an alias of count.

I am still testing this, but if all goes well, will post the patch shortly.

Comment 3

[Andrew Miller]

Attachment: Adds length (alias of count) to nsITreeColumns and implements on nsTreeColumns

Comment 4

[Andrew Miller]

Attachment: As before, but bumps IID

Comment 5

[[e-mail]]

Comment on attachment 233000 [details] [diff] [review]
As before, but bumps IID

I can't get to this this week so trying Enn instead.

Comment 6

[Neil Deakin]

Comment on attachment 233000 [details] [diff] [review]
As before, but bumps IID

Looks OK, but get a DOM person to sr it as well.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 233000 [details] [diff] [review]
As before, but bumps IID

sr=jst

Comment 8

[Michael Wu [:mwu]]

Checking in layout/xul/base/src/tree/src/nsTreeColumns.cpp;
/cvsroot/mozilla/layout/xul/base/src/tree/src/nsTreeColumns.cpp,v  <--  nsTreeColumns.cpp
new revision: 1.16; previous revision: 1.15
done
Checking in layout/xul/base/src/tree/public/nsITreeColumns.idl;
/cvsroot/mozilla/layout/xul/base/src/tree/public/nsITreeColumns.idl,v  <--  nsITreeColumns.idl
new revision: 1.4; previous revision: 1.3
done