332843 - Make old urls redirect to v2 urls.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Cameron]

We ought to make old urls redirect to new ones. It doesn't have to be perfect, but yeah. Anyone with extensions that point at pages, links on their sites and bookmarks will appreciate it.

https://addons.mozilla.org/extensions/moreinfo.php?id=398&application=firefox currently points at/is the same as https://addons.mozilla.org/firefox/398/ but if there's anything else in the url, it messes it. 

eg:
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398&&page=comments
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398&page=releases
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398&page=staffreview
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398&page=opinion
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398&page=previews
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=398&vid=123456789
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&category=Popular&numpg=10&id=398

Etc. etc. etc.

Basically, I don't think it's particularly important to make them all link to their new locations, although it could be kinda nifty, but it's easier to just make anything with application=firefox and &id=123 (note the &, otherwise it will pick up vid aswell) in the url point at https://addons.mozilla.org/firefox/123/

Anything with application=mozilla in the url can point at https://addons.mozilla.org/mozilla/123/ and likewise for thunderbird.

Additionally, we ought to make author profiles work in the same way. https://addons.mozilla.org/extensions/authorprofiles.php?id=473 should point at https://addons.mozilla.org/foo/473/author/
I'm currently not quite sure about the author profile links and what we should replace foo with, but ah well, you get the idea.

Comment 1

[Cameron]

http://groups.google.com/group/mozilla.support.firefox/browse_frm/thread/2633f8b4725a78d6/ccc731b9a881d0b5#ccc731b9a881d0b5

Should make old RSS feed links point too new ones.

Comment 2

[Cameron]

*** Bug 333567 has been marked as a duplicate of this bug. ***

Comment 3

[Cameron]

Organising bugs. Sorry for the bugspam.

Comment 4

[Wladimir Palant]

I don't think anybody cares about comment links and the such. But links like https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=1865 or even https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&category=Newest&numpg=5&id=1865 are very common and currently they don't work. Check out Firefox Facts ebook (http://www.firefoxfacts.com/ebook/FirefoxFacts.zip) for example, lots of unusable links there. I think that's a top priority.

Comment 5

[Wladimir Palant]

Attachment: Proposed patch

Adjusting rewrite rules in htaccess.dist. Changes:

1. Made the redirects from /extensions/ and /themes/ 301 Moved Permanently - this is very important for search engines and simply good style.
2. Made several typical old-style links redirect to the current /firefox/123/ - the user should see the correct link.

Comment 6

[Michael Morgan [:morgamic]]

Comment on attachment 221225 [details] [diff] [review]
Proposed patch

Looks good, except the hard-coded rewritebase for the new rewrites.  Stripping those out and checking this in.

Comment 7

[Michael Morgan [:morgamic]]

Committed -- will push up to sysadmins for insertion into .conf.

Comment 8

[Cameron]

I'm not quite sure about resolving this bug just yet. Eg - old rss urls, old author profile urls - do we think these are important?

Additionally, despite my specifically noting the similarity between id and vid, you bugled it up anyway trev :D See bug 338609 ;)

Comment 9

[Wladimir Palant]

Well, whoever was subscribed to RSS, probably noticed that the links stopped working a while ago. And I don't think there are external links to these. Author profile links might be worth fixing on the other hand.

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

If we need access to web server logs to see what URLs are actually being hit, we should get them.  Guessing about what pages are in use is a bad plan, and leads to pain.

It might be OK to break some pages, but we should do it very explicitly, and if there's somewhere else we can point them at that's equivalent then we should do that.