Closed Bug 332866 Opened 18 years ago Closed 17 years ago

Buttons with "Open"/"Edit" for events/tasks should be added to the Calendar Alarm window

Categories

(Calendar :: Alarms, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Aleks.Ehrlich, Assigned: giermann)

References

Details

Attachments

(4 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

When a calendar alarm is fired Calendar Alarm window is displayed with buttons "Dismiss" and "Dismiss All". A new button "Open" should be added near (each) "Dismiss" button opening the corresponding item.

Reproducible: Always
Sunbird version 0.3a+ (April 04, 2006 binary build).
Component: Sunbird Only → Alarms
OS: Windows XP → All
QA Contact: sunbird → alarms
Hardware: PC → All
Summary: RFE: A button "Open item" should be added to the Calendar Alarm window (like in MS Outlook) → Buttons with "Open"/"Edit" and "Delete" for events/tasks should be added to the Calendar Alarm window (like in MS Outlook)
*** Bug 349982 has been marked as a duplicate of this bug. ***
Status: UNCONFIRMED → NEW
Depends on: 341576
Ever confirmed: true
Summary: Buttons with "Open"/"Edit" and "Delete" for events/tasks should be added to the Calendar Alarm window (like in MS Outlook) → Buttons with "Open"/"Edit" and "Delete" for events/tasks should be added to the Calendar Alarm window
Version: unspecified → Trunk
This would bring back the 'Edit' button to the alarm widgets, as it existied in version 0.2!

It also solves the mis-placement of the 'Dismiss' button, mentioned in Bug 356056 [1].
To get the resolution more quickly, I also request to remove the dependence on bug 341576, because it addresses more complicated UI modifications. This patch can be seen as a first step, bringing the function and leaving the UI (nearly) untouched.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=356056#c8
Attachment #281469 - Flags: ui-review?(philipp)
Attachment #281469 - Flags: review?(daniel.boelzle)
Comment on attachment 281469 [details] [diff] [review]
Comeback of the Edit button

Moving reviews to appropriate reviewers. Our UI reviewer is mostly Christian and either mickey or I do Calendar-Views reviews. I am on vacation right now though :)
Attachment #281469 - Flags: ui-review?(philipp)
Attachment #281469 - Flags: ui-review?(christian.jansen)
Attachment #281469 - Flags: review?(michael.buettner)
Attachment #281469 - Flags: review?(daniel.boelzle)
Assignee: nobody → giermann
Version: Trunk → unspecified
Status: NEW → ASSIGNED
I'm on a conference, if I have some time free. I'll review it (ASAP...)
Comment on attachment 281469 [details] [diff] [review]
Comeback of the Edit button

ui+ with the following changes:

- Add ellipses to the "Edit" button
- increase the vertical space between Edit and the "snooze for N minutes" row.
Attachment #281469 - Flags: ui-review?(christian.jansen) → ui-review-
it will be very helpful to have this 'edit' button when you come back from holiday and suddenly 10 events fire
Flags: blocking-calendar0.7?
(In reply to comment #8)
> - Add ellipses to the "Edit" button
Would be possible, but requires an additional locale string - so the check-in would not be possible for 0.7 release...

> - increase the vertical space between Edit and the "snooze for N minutes" row.
I tried to waste as little space as possible, but to suite your proposals in Bug 341576, I will attach 2 new proposals.


Attached image Proposal 2
I have 'stolen' the locale from 'calendar.error.detail' - an additional string would be recommended...
Attachment #282113 - Flags: ui-review?(christian.jansen)
Attached image Proposal 3
Sven, I am working on creating a better alarm event dialog, see bug 341576. I already have a lot of code working there. Maybe you have some ideas for that bug? I believe with the implementation there, this bug would become obsolete.
Philipp, I agree that the new UI in bug 341576 looks much better and it would be great to work on these both together...

I would suggest to leave only the code for calling the Event dialog (onEditAlarm) and the rest could be done in XUL...
I also have a look on bug 341576, but it seems the UI people disagree on the best solution...
Comment on attachment 281469 [details] [diff] [review]
Comeback of the Edit button

Sven, I'm really sorry I didn't take a deeper look at your code earlier, I also overlooked the fact you already knew about bug 341576.

I'm r-'ing this code for now, not because of my work on the other bug, but more because onEditAlarm only looks for thunderbird windows.

If its OK with you, I'll use code from your patch in the new dialog.
Attachment #281469 - Flags: review?(michael.buettner) → review-
Comment on attachment 282113 [details]
Proposal 2

Removing ui-review because new event dialog is under development (see bug 341576).
Attachment #282113 - Flags: ui-review?(christian.jansen)
helping to mass reassign from requesting blocking‑calendar0.7 to wanted‑calendar0.8.
Flags: blocking-calendar0.7? → wanted-calendar0.8?
It would be good to have this in 0.8
Flags: wanted-calendar0.8? → wanted-calendar0.8+
Bug 341576 added a "Details..." button that shows the Edit Event/Task dialog for the occurrence selected in the alarm dialog. In my opinion this bug can be resolved as fixed.
Stefan, I agree. Fixed by patch from bug 341576.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: Buttons with "Open"/"Edit" and "Delete" for events/tasks should be added to the Calendar Alarm window → Buttons with "Open"/"Edit" for events/tasks should be added to the Calendar Alarm window
Target Milestone: --- → 0.8
Verified with Lightning 2008012710 and Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.12pre) Gecko/20080127 Calendar/0.8pre
Status: RESOLVED → VERIFIED
VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre 2008012719 Thunderbird/2.0.0.9 ID:2007103104
You need to log in before you can comment on or make changes to this bug.