332949 - initial menu item enabled state often incorrect

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

1. Open Cocoa Firefox
2. Close initial window with mouse
3. Hit command-w

Since no windows are open at this point, command-w should be disabled. However, it does not get disabled until you show the menu on screen. If for step 3 you try to use the mouse you won't have this problem because the menu is shown on the screen.

We should definitely fix menu updating, and maybe also not crash even if the bad command does get sent.

Comment 1

[Asaf Romano (gone)]

Note this was always an issue in Carbon widget, AFAICT the command isn't fired.

Comment 2

[Håkan Waara]

Every time you open a menu, all items are recreated, so it may be due to the fact that the command handlers do not point at the right items then?

(BTW, DOM inspector on mac seems to be broken where the fundamental problem is in the way we tear down menus as soon as you turn your back on them; I debugged this a few months ago.)

Comment 3

[Josh Aas]

Attachment: fix v1.0

When a menu item is initially created, its enabled state is pulled from its own DOM node, which is inaccurate until the state changes for the first time or the menu item is updated via the OnCreate handler. Since enabled state matters even when menus are not open, we should dig it out from the command content instead of the DOM node content when the nsMenuItem object is created.

Comment 4

[Mark Mentovai]

Comment on attachment 225754 [details] [diff] [review]
fix v1.0

Excellent!

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 225754 [details] [diff] [review]
fix v1.0

sr=pink

Comment 6

[Josh Aas]

fixed on trunk