333025 - Three relatively frequent mozilla/accessible crashes in talkback

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The following 3 crashes reoccur fairly regularly in talkback.

http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17265983
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17265867
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17264754

I'd like to take care of them all at once.

Comment 1

[Aaron Leventhal]

Attachment: Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

Comment 2

[Aaron Leventhal]

Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

Ginn, I shouldn't a= my own patches.

Comment 3

[Ginn Chen]

Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

a=me

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

1.8.0.2 is done, moving aaron's request to 1.8.0.3

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

approved for 1.8.0 branch, a=dveditz for drivers

Comment 6

[Ginn Chen]

Checking in src/base/nsDocAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v  <--  nsDocAccessible.cpp
new revision: 1.73.2.6.2.1; previous revision: 1.73.2.6
done
Checking in src/msaa/nsDocAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v  <--  nsDocAccessibleWrap.cpp
new revision: 1.30.2.4.2.1; previous revision: 1.30.2.4
done