Three relatively frequent mozilla/accessible crashes in talkback

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

(5 keywords)

Trunk
x86
Windows XP
access, crash, fixed1.8.0.4, fixed1.8.1, topcrash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The following 3 crashes reoccur fairly regularly in talkback.

http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17265983
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17265867
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17264754

I'd like to take care of them all at once.
(Assignee)

Comment 1

11 years ago
Created attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.
Attachment #217449 - Flags: superreview?(neil)
Attachment #217449 - Flags: review?(pilgrim)

Updated

11 years ago
Attachment #217449 - Flags: superreview?(neil) → superreview+

Updated

11 years ago
Summary: Three relatively mozilla/accessible crashes in talkback → Three relatively frequent mozilla/accessible crashes in talkback

Updated

11 years ago
Attachment #217449 - Flags: review?(pilgrim) → review+
(Assignee)

Comment 2

11 years ago
Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

Ginn, I shouldn't a= my own patches.
Attachment #217449 - Flags: approval-branch-1.8.1?(ginn.chen)
(Assignee)

Updated

11 years ago
Attachment #217449 - Flags: approval1.8.0.2?
(Assignee)

Updated

11 years ago
Blocks: 333488

Comment 3

11 years ago
Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

a=me
Attachment #217449 - Flags: approval-branch-1.8.1?(ginn.chen) → approval-branch-1.8.1+
Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

1.8.0.2 is done, moving aaron's request to 1.8.0.3
Attachment #217449 - Flags: approval1.8.0.2? → approval1.8.0.3?
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
Comment on attachment 217449 [details] [diff] [review]
Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point.

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #217449 - Flags: approval1.8.0.3? → approval1.8.0.3+

Comment 6

11 years ago
Checking in src/base/nsDocAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v  <--  nsDocAccessible.cpp
new revision: 1.73.2.6.2.1; previous revision: 1.73.2.6
done
Checking in src/msaa/nsDocAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v  <--  nsDocAccessibleWrap.cpp
new revision: 1.30.2.4.2.1; previous revision: 1.30.2.4
done
Keywords: fixed1.8.0.3
Keywords: crash
You need to log in before you can comment on or make changes to this bug.