Closed
Bug 333040
Opened 19 years ago
Closed 19 years ago
Cannot search based on "Attachment Creator"
Categories
(Bugzilla :: Query/Bug List, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.04 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
I would like to be able to use boolean charts to look for bugs where:
"Attachment creator" "is" foo@bar.com
Updated•19 years ago
|
Summary: Cannot query for bugs where some user posted an attachment → Cannot search based on "Attachment Creator"
| Assignee | ||
Comment 1•19 years ago
|
||
It's the first time I hack Search.pm, so don't trust this patch too much. :)
Assignee: query-and-buglist → LpSolit
Status: NEW → ASSIGNED
Attachment #237507 -
Flags: review?(bugreport)
| Assignee | ||
Updated•19 years ago
|
Target Milestone: --- → Bugzilla 3.0
| Assignee | ||
Comment 2•19 years ago
|
||
For consistency with the UI of the attachment table, let's call it "attachment creator" instead of "attachment submitter".
Attachment #237507 -
Attachment is obsolete: true
Attachment #237509 -
Flags: review?(bugreport)
Attachment #237507 -
Flags: review?(bugreport)
| Assignee | ||
Comment 3•19 years ago
|
||
joel, did you have time to test this patch?
Comment 4•19 years ago
|
||
I did not, but I did have time to inspect it and the logic is correct. So, if someone wants to r+ it based on coding standards and testing, they can be reassured by my insepction results.
Comment 5•19 years ago
|
||
| Assignee | ||
Comment 6•19 years ago
|
||
But this query doesn't only find attachments I posted, but also those I changed I guess. ;)
Comment 7•19 years ago
|
||
(In reply to comment #6)
> But this query doesn't only find attachments I posted, but also those I changed
> I guess. ;)
>
True, but you can't edit the attachment data after posting it.
Comment 8•19 years ago
|
||
Comment on attachment 237509 [details] [diff] [review]
patch, v1.1
Looks good, works fine!
Attachment #237509 -
Flags: review?(bugreport) → review+
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
| Assignee | ||
Comment 9•19 years ago
|
||
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v <-- Field.pm
new revision: 1.22; previous revision: 1.21
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm
new revision: 1.141; previous revision: 1.140
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•