333058 - search.php produces non valid html

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Cameron]

<input type="hidden" name="app" value="firefox"/> has to be inside a <div> (or something else) inside <form>

Comment 1

[alanjstr]

I don't understand.  form is a block level item and input is an inline item.  Why would it have to be inside of the div?  I just noticed that this line is in there twice.  Could that do it?

# <div class="key-point">
#
# <form action="/search.php" method="get" class="amo-form">
# <input type="hidden" name="app" value="firefox"/>
#
# <div>

# <!-- end search-options -->
# </div>
#
# <input type="hidden" name="app" value="firefox"/>
# </form>

Comment 2

[alanjstr]

Do we even need this hidden field?  search has <select id="appfilter" name="appfilter"> which will have a value of whatever we're trying to show.

Comment 3

[Wil Clouser [:clouserw]]

Attachment: Moves the <input>s inside a <div>

In the HTML 4.01 specs they always have another block level element inside the form tag.  It's weird tidy doesn't catch this though (in the html validator extension).  Anyway, here is a patch that fixes it, and it's in cvs now.