33310 - [MLK] Leaking nsIWeakReference

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Patrick C. Beard]

This line:

 mServer = NS_GetWeakReference(server);

leaks a reference count, and should always be written as:

 mServer = getter_AddRefs(NS_GetWeakReference(server));

Comment 1

[Patrick C. Beard]

Reassigning to alecf, since he probably wrote the code.

Comment 2

[Alec Flett]

doh! thanks. I found 4 other occurances of this same broken pattern too

Comment 3

[Alec Flett]

Attachment: patch for lots of weakref fixes

Comment 4

[Alec Flett]

all fixed, thanks to bruce for the review.

Comment 5

[chuang]

Verified in code.