Closed Bug 333172 Opened 14 years ago Closed 13 years ago

minVersion should be a fixed number, don't link against layout for DOM Inspector

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

This is separated out from the review of bug 331758.

minVersion should be a fixed and not floating number. To do this, we need to make sure that DOMI doesn't link against layout so that it will be able to be used against more than one version of Mozilla application(s).
Looks like bug 325100 has just removed the linking against layout for DOMI. Therefore I believe we should be able to implement this bug?
Depends on: 325100
Depends on: 367621
Depends on: 271812
Blocks: 271812
No longer depends on: 271812
So, what should this be set to?  On trunk we'd have to set the minVersion to something like 3.0a1 maybe?

Should we set the max version to 3.0.* (or 3.0.0.*)?
Assignee: dom-inspector → comrade693+bmo
I think you still support old versions in trunk DOMi. So minVersion should be whatever minimum version you support. The maxVersion should be as it is now (i.e. 3.0a2 (iirc) for trunk). Do not use 3.0 and its variations since you can't promise to support something that's not released.
(In reply to comment #3)
> I think you still support old versions in trunk DOMi. So minVersion should be
> whatever minimum version you support. The maxVersion should be as it is now
> (i.e. 3.0a2 (iirc) for trunk). Do not use 3.0 and its variations since you
> can't promise to support something that's not released.

That's a good point, but I am pretty sure that we've made changes to the c++ components that didn't land on branch, so it would only be trunk.

It should also be noted that my previous numbers were for browser, and I have no idea what the others should be set to.
Status: NEW → ASSIGNED
(In reply to comment #4)
> It should also be noted that my previous numbers were for browser, and I have
> no idea what the others should be set to.

Check the version.txt files for a starting point - typically in mozilla/<app specific dir>/config/version.txt. SeaMonkey should be set to 1.5a minimum, as that's SM's current trunk version - and like you say, I think the c++ changes only made it on trunk.
AFAIK DOMi on 1.8 branch doesn't link against layout either - this broke the OS/2 installer builds which didn't remove the old DOMi library.
Attached patch v1.0Splinter Review
should do it.
Neil r for Suite, Mail
Gavin r for Browser
Joey r for Calendar
Attachment #252259 - Flags: superreview?(neil)
Attachment #252259 - Flags: review?(neil)
Attachment #252259 - Flags: review?(jminta)
Attachment #252259 - Flags: review?(gavin.sharp)
Attachment #252259 - Flags: review?(gavin.sharp) → review+
Attachment #252259 - Flags: superreview?(neil)
Attachment #252259 - Flags: superreview+
Attachment #252259 - Flags: review?(neil)
Attachment #252259 - Flags: review+
Attachment #252259 - Flags: review?(jminta) → review+
checked in by timeless
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.