fix image cursors for cairo-gtk2 builds

RESOLVED FIXED in mozilla1.9alpha1

Status

()

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.9alpha1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

Image cursors are broken because nsThebesImage doesn't implement nsIGdkPixbufImage.
Created attachment 217623 [details] [diff] [review]
patch
Assignee: nobody → cbiesinger
Status: NEW → ASSIGNED
Attachment #217623 - Flags: review?(pavlov)
Target Milestone: --- → mozilla1.9alpha

Comment 2

13 years ago
Comment on attachment 217623 [details] [diff] [review]
patch

i'd really rather not take this patch.  we want to remove our deps on nsIImage and the rest of the GFX APIs as much as possible.  Can this code live somewhere else?
Yes, the fix for this needs to happen in widget code, not in gfx; same for that WriteImage stuff.
Attachment #217623 - Flags: review?(pavlov) → review-
Created attachment 217690 [details] [diff] [review]
patch v2

maybe like this then?
Attachment #217623 - Attachment is obsolete: true
Attachment #217690 - Flags: review?(bryner)
Comment on attachment 217690 [details] [diff] [review]
patch v2

Looks ok... the comments about nsIGdkPixbufImage will be confusing when that interface goes away though.
Attachment #217690 - Flags: review?(bryner) → review+
Created attachment 225657 [details] [diff] [review]
patch v2, merged to trunk

oops, I forgot about this patch...
Attachment #217690 - Attachment is obsolete: true
Attachment #225657 - Flags: superreview?(roc)
Why don't you just create a GdkPixbuf, wrap it in a gfxContext, and draw the image into that?
Cairo does not support the pixel format of GdkPixbuf. GdkPixbuf wants non-premultiplied RGBA (big-endian byte order).
sorry, I confused GdkPixbuf with GdkPixmap.
Attachment #225657 - Flags: superreview?(roc) → superreview+
Checking in browser/components/shell/src/nsGNOMEShellService.cpp;
/cvsroot/mozilla/browser/components/shell/src/nsGNOMEShellService.cpp,v  <--  nsGNOMEShellService.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in widget/src/gtk2/Makefile.in;
/cvsroot/mozilla/widget/src/gtk2/Makefile.in,v  <--  Makefile.in
new revision: 1.53; previous revision: 1.52
done
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsIImageToPixbuf.h,v
done
Checking in widget/src/gtk2/nsIImageToPixbuf.h;
/cvsroot/mozilla/widget/src/gtk2/nsIImageToPixbuf.h,v  <--  nsIImageToPixbuf.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.cpp,v
done
Checking in widget/src/gtk2/nsImageToPixbuf.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.cpp,v  <--  nsImageToPixbuf.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.h,v
done
Checking in widget/src/gtk2/nsImageToPixbuf.h;
/cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.h,v  <--  nsImageToPixbuf.h
initial revision: 1.1
done
Checking in widget/src/gtk2/nsWidgetFactory.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWidgetFactory.cpp,v  <--  nsWidgetFactory.cpp
new revision: 1.36; previous revision: 1.35
done
Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.173; previous revision: 1.172
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.