333185 - Comments can be rated an unlimited number of times by the same user (Was this comment helpful?)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Chris Wood]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

I rated a comment on an extension. I noticed when I went back to the extension page, that "X of X viewers found this comment helpful" had not incremented immediately, I don't know if this has anything to do with the bug.

Then the latest AMO update was applied, and I logged in again under a different IP (again, not sure if IP is relevant). I then saw that "X of X viewers found this comment helpful", and I tried rating the comment again. After a bit, the comment rating counter incremented - I had successfully rated the same comment twice.

Probably all comments rated before the update can be rated again?

Reproducible: Always



Expected Results:  
A user should not be able to rate a comment more than once.

Comment 1

[Chris Wood]

Okay, because of comment rating takes a while to update, I didn't notice, but actually this bug is very straightforward - a user can rate a comment an unlimited number of times. The counter just doesn't update immediately.

This has probably been abused already.

Comment 2

[Chris Wood]

Eg. https://addons.mozilla.org/addon.php?id=1767 23 ratings were made by a single viewer (myself).

Comment 3

[Cameron]

Organising bugs. Sorry for the bugspam.

Comment 4

[Mike Shaver (:shaver emeritus)]

I dunno what we'll do about this, exactly, but we should at least put a plan together for the 2.1 update. (To the batqueue!)

Comment 5

[Wil Clouser [:clouserw]]

Due to the database schema, we don't actually track anything on a per-rating basis (it just increment's the count), so this could potentially be a significant modification. :(

/me heads to the batcave.

Comment 6

[Wil Clouser [:clouserw]]

In Remora, ratings are rolled into Reviews, and Reviews need to be approved by an editor before they are live, which should prevent rating spam.  Marking this as fixed.