333313 - oom mlk in InternetSearchDataSource::BeginSearchRequest

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[timeless]

found by coverity

this bug dates to rev 1.89

things to do:
1. fix the code to honor the comment which dates to rev 1.17 or earlier so that it stops leaking.
2. fix the comment to use it's and its properly:

3189                        // if its a engine from a search category, then get its "#Name",

if it's (it is) an engine from a search category then get its (possessive) "#Name",

(there are two changes to the line, don't just fix its).

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v1

rev 1.17 indeed: as timeless said, since NS_RDF_NO_VALUE means trueEngine's still nsnull, it was fine as it was then.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

mozilla/xpfe/components/search/src/nsInternetSearchService.cpp 	1.248