333431 - RSS feed linked from AMO pages 404s.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Christopher Finke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

The RSS feed linked from this page via the <link rel="alternate" type="application/rss+xml" title="New Firefox Extensions Additions" href="/rss/?app=firefox&amp;type=E&amp;list=newest"> code in the header is not an RSS feed; it just redirects to the main extensions home page. This causes a "Live Bookmark Failed to Load" error when the feed is added via the RSS icon in the address bar.

Reproducible: Always

Steps to Reproduce:
1. Navigate to https://addons.mozilla.org/firefox/extensions/
2. Click on the orange RSS icon in the address bar.
3. Click "OK" in "Add Live Bookmark" dialog.
4. View live bookmark.

Actual Results:  
Will show "failed to load" error.

Expected Results:  
Should show contents of feed.

Comment 1

[Reed Loden [:reed]]

--> Update :: Web Site

Comment 2

[Cameron]

Needs to be pointed at {$config.webpath}/rss/{$app}/extensions/updated/

I'd do it myself if I knew where the code was :s

Comment 3

[Cameron]

Found it! :)

Comment 4

[Cameron]

Attachment: Points at new RSS link

This should make it do newest Firefox extensions on the mainpage, but if you click themes, then it should be newest firefox themes, if you click thunderbird, it should do thunderbird etc. 

See related Bug 332843 - we should make it so people who have already subscribed to the feed get redirected.

Comment 5

[Cameron]

Attatchment 217881 will always point at the newest extensions for Firefox, Thunderbird or Seamonkey. Won't do themes. Not quite sure how I'd do that.. might have to use:

{$config.webpath}/rss/{$app}/{if $currentTab eq "themes"}themes{else}extensions{/if}/updated/

but I really need a bit of help with this methinks :)

Comment 6

[Cameron]

Attachment: Points at new RSS link

Attempt to put themes RSS link on themes pages, extensions on other pages. Tries to get app aswell, not sure how that will work. Also, I changed it from updated to newset. Who wants to know when something was updated? - they want new stuff.

Todo: Make it so it will capitalise the app name in the title, but not in the url.

Comment 7

[Cameron]

Oops

Comment 8

[Christopher Finke]

> Who wants to know when something was updated?
> they want new stuff.

I don't know about anyone else, but I'd want to see both new extensions and updates of existing extensions.

Comment 9

[Cameron]

(In reply to comment #8)
> > Who wants to know when something was updated?
> > they want new stuff.
> 
> I don't know about anyone else, but I'd want to see both new extensions and
> updates of existing extensions.

Hmm. Well people can still go to the updated feed from the feeds.php page, this will just be for the auto-detection stuff. I suppose we could always put both...

anyone else got any ideas on this?

Comment 10

[Cameron]

Comment on attachment 218152 [details] [diff] [review]
Points at new RSS link

lets get this tested and checked in. If we want to change it, we can change it later. At the moment, the user experience is just sucky.

Clouser: I haven't tested this at all myself. Waiting for help with setting up a dev environment :(

Comment 11

[Michael Morgan [:morgamic]]

Comment on attachment 218152 [details] [diff] [review]
Points at new RSS link

This will produce an incorrect live bookmark link, because {$app} is not defined at this point -- something we should fix globally (instead of assigning {$app} from $_GET in Smarty, which is a DirtyHack(tm).

Comment 12

[Cameron]

So... what would you propose morgamic?

Comment 13

[Wladimir Palant]

Hm, I see that the first (obsolete) patch was applied. The URL is still wrong, because it uses the $app variable before it is set. Bug 337198 should fix this, adding a dependency.

Comment 14

[Cameron]

I got nuthin'

Comment 15

[Wil Clouser [:clouserw]]

Attachment: quick fix

This should fix this problem in the short term until we deal with the bigger issues.

Comment 16

[Michael Morgan [:morgamic]]

Comment on attachment 225590 [details] [diff] [review]
quick fix

Looks good to me (will have to note this when looking at bug 337198).

Comment 17

[Wil Clouser [:clouserw]]

Thanks morgamic.  Patch is in cvs.

Comment 18

[Michael Morgan [:morgamic]]

These were pushed about an hour ago - fyi.

Comment 19

[Cameron]

Reopening. On the Mozilla suite and Thunderbird homepages (ie https://addons.mozilla.org/mozilla/ and https://addons.mozilla.org/thunderbird/ ) the {$smarty.get.app} stuff aint working, resulting in 404s at https://addons.mozilla.org/rss//extensions/newest/

Comment 20

[Cameron]

Update. 404s on any page except /app/extensions/ and /app/themes/

so.. 404s on add-ons' listing pages, 404s on faq, support, plugins, search-plugins pages etc. etc. etc.

That's a lot of 404s. Escalating.

Comment 21

[Michael Morgan [:morgamic]]

I saw a couple of other things after I spent more time looking at it -- $smarty.get.app should be escaped, nonav-header.tpl needed to be updated too.  :(

Ultimately, the DirtyHack if statements for the header image should just be at the top of the header file, but we don't want to spend more time on this -- would rather review trev's patch for app params.

Checked in the fix.

Comment 22

[Michael Morgan [:morgamic]]

*** Bug 343062 has been marked as a duplicate of this bug. ***

Comment 23

[Michael Morgan [:morgamic]]

Public site wasn't updated yet -- will put in a request for that.

Comment 24

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Public site got updated, I do believe, but we're still seeing it.  I'll try to take a look today.

Comment 25

[Michael Morgan [:morgamic]]

Public site hasn't been updated yet -- we are going to update as a batch with a couple of other patches I'm working on.

Comment 26

[Wil Clouser [:clouserw]]

Public site has been updated.  This looks fixed to me.