333485 - MozillaInterfaces*.jar in dist/bin/sdk/lib

Status: RESOLVED WORKSFORME

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[Mike Hommey [:glandium]]

MozillaInterfaces.jar and MozillaInterfaces-src.jar are installed in dist/bin/sdk/lib. It would make more sense for them to be installed in dist/lib/sdk/lib so that they get shipped with the sdk tarball, not the xulrunner (or anything else that includes javaxpcom) application tarball.

On a side note, these files (and the javaxpcom.jar file) are not installed by make install.

Comment 1

[Mike Hommey [:glandium]]

woops they already are installed in dist/sdk/lib, which is fine, but are they any useful in the application tarball (dist/bin/sdk/lib) ? MozillaInterfaces-src.jar is indeed not, MozillaInterfaces.jar might, at least for the Glue part that should be separated (cf. bug #328901). OTOH, this is runtime, not sdk, so if the glue is useful, it should just go in dist/bin, not dist/bin/sdk/lib.

Comment 2

[jhp (no longer active)]

These files are installed in dist/bin/sdk/lib so that people who download XULRunner can make use of them.  Since there is currently no SDK release (should be remedied soon, I believe), the decision was made to ship them with XULRunner.  Once the SDK ships, we can remove MozillaInterfaces-src.jar, although I think we should still ship MozillaInterfaces.jar (even split in two) with XULRunner.

Comment 3

[Mike Hommey [:glandium]]

since the MozillaInterfaces.jar is not part of the sdk, but of the runtime, it should not live in sdk/lib in the application tarball, don't you think ?

Comment 4

[jhp (no longer active)]

Now that I think about it, MozillaInterfaces.jar is somewhat special in that a Java app would need to pull it in in order to use, much in the same way a C++ app compiles against xpcomglue.  So yes, both files should probably ship with the SDK and not with XULRunner.

bsmedberg, what do you think?

Comment 5

[Benjamin Smedberg]

As far as I understand it both of these are intended for the SDK, and we only put them in dist/bin/sdk for the time being since we don't have the SDK build system in place yet. They are not part of the XULRunner runtime.

Comment 6

[Mike Hommey [:glandium]]

The thing is... if I take the TestJavaProxy test, and try it, I need both javaxpcom.jar and MozillaInterfaces.jar at runtime. One would expect to only require javaxpcom.jar...

Comment 7

[jhp (no longer active)]

(In reply to comment #6)
> The thing is... if I take the TestJavaProxy test, and try it, I need both
> javaxpcom.jar and MozillaInterfaces.jar at runtime.

Correct.  A Java developer codes against the interfaces and bootstrapping classes in MozillaInterfaces.jar.  Under the covers, it loads javaxpcom.jar and the JNI file, but this is irrelevant to the Java dev; he should only concern himself with what is in MozillaInterfaces.jar.

Comment 8

[Mike Hommey [:glandium]]

but in that case, the MozillaInterfaces.jar file should be in the runtime as well as in the SDK...

Comment 9

[jhp (no longer active)]

No, MozillaInterfaces.jar shouldn't be in the runtime (and wouldn't be used there).  A Java program links against, and would need to ship, MozillaInterfaces.jar, which is used to find and load an installed XULRunner (the runtime).

Comment 10

[jhp (no longer active)]

In the check in to bug 333618, I removed the Makefile lines that copied these jars into dist/bin/sdk/lib.  So closing this bug.