333591 - Clear Private Data does not clear Saved Form Information

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:
- Set Clear Private Data to set Saved Form Information on close
- Restart Firefox
- The form information is still there
NB: In the Privacy > Saved Form tab in the Options window this button is grayed out.

I'm nearly positive that I reported this before, but I can't find the bug so I think it is closed but the problem is still there.

Comment 1

[Bryan]

Confirming bug!  Still seeing this in the latest branch build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060414 Firefox/2.0a1 ID:2006041410

Comment 2

[Ria Klaassen (not reading all bugmail)]

This is still the case in the places-less branch builds (I still see the sqlite file in the branch profile).

Comment 3

[Mike Connor [:mconnor]]

There's a bug to switch back to using Mork for form history on the branch, though I'm not sure what's up there.  Brett, care to fill in the blanks here?

Comment 4

[Hussam Al-Tayeb]

*** Bug 336815 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

retargetted at beta1

Comment 6

[Hussam Al-Tayeb]

Can't we just have 'Saved Form Information' clear 'formhistory.sqlite' as well if it exists?

Comment 7

[Pam Greene]

I've confirmed this on nightlies from 1.8 branch (without Places) and trunk (with Places).  It appears that the service is not correctly detecting when form information is present.  It does need to be fixed for FF2b1, but it's not a Places bug -- not sure which component it properly belongs to.

Comment 8

[Ria Klaassen (not reading all bugmail)]

There is no component Privacy, Security seems exaggerated and only Preferences or General seems to be appropriate.

Comment 9

[Hussam Al-Tayeb]

Can somebody change the OS to all? I see this in my Linux builds as well.

Comment 10

[Pam Greene]

Attachment: Fixes two problems producing this bug

Fixes error in nsStorageFormHistory that caused it to never see form history entries, as well as restoring searchbar.mTextbox so sanitize.js can clear it.

Comment 11

[Brian Ryner (not reading)]

Comment on attachment 222277 [details] [diff] [review]
Fixes two problems producing this bug

mFoo is generally a convention for private member variables, so I think using it here is a bad idea (especially since there already is a "private" member _textbox).

I think a better solution would be to name the property just "textbox" and change sanitize.js to match.

Comment 12

[Pam Greene]

Attachment: Patch addressing Bryan's comments

(In reply to comment #11)
> I think a better solution would be to name the property just "textbox" and
> change sanitize.js to match.

Done.

Comment 13

[Brian Ryner (not reading)]

checked in