test for ARM in config/Linux.mk is too specific

RESOLVED FIXED in 4.0.2

Status

NSPR
NSPR
P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: pb, Assigned: Wan-Teh Chang)

Tracking

4.0.2
Other
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
This patch allows ARM systems other than v4l and SA110 to be correctly detected.

Index: Linux.mk
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/config/Linux.mk,v
retrieving revision 3.16.2.1
diff -u -p -r3.16.2.1 Linux.mk
--- Linux.mk	2000/03/08 16:24:48	3.16.2.1
+++ Linux.mk	2000/03/26 12:45:42
@@ -50,7 +50,7 @@ endif
 ifeq (86,$(findstring 86,$(OS_TEST)))
 CPU_ARCH		:= x86
 else
-ifeq (,$(filter-out armv4l sa110,$(OS_TEST)))
+ifeq (,$(filter-out arm% sa110,$(OS_TEST)))
 CPU_ARCH		:= arm
 else
 CPU_ARCH		:= $(OS_TEST)
(Assignee)

Comment 1

18 years ago
Thanks for the bug report.  Before I check in
your patch, I need to ask you a question.  We
are going to change the license terms of NSPR
to dual MPL/GPL.  Would you let us distribute
your patch under MPL/GPL?
Assignee: srinivas → wtc
(Reporter)

Comment 2

18 years ago
Yes, that's fine.
(Assignee)

Comment 3

18 years ago
I'm just curious -- what does 'uname -a' return on
your system?
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Version: 3.0 → 4.0
(Assignee)

Comment 4

18 years ago
Checked in the patch on the main trunk.
/cvsroot/mozilla/nsprpub/config/Linux.mk, revision 3.18

Checked in the patch on the NSPRPUB_RELEASE_4_0_BRANCH.
/cvsroot/mozilla/nsprpub/config/Linux.mk, revision 3.15.8.3

Will check it in on the NSPRPUB_CLIENT_BRANCH (which the
mozilla client pulls) when the mozilla tree reopens.
(Assignee)

Comment 5

18 years ago
Checked in the patch on the NSPRPUB_CLIENT_BRANCH.
/cvsroot/mozilla/nsprpub/config/Linux.mk, revision 3.16.2.2
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Updated

18 years ago
Target Milestone: --- → 4.0.1
(Assignee)

Updated

18 years ago
Target Milestone: 4.0.1 → 4.0.2
You need to log in before you can comment on or make changes to this bug.