Closed
Bug 333640
Opened 17 years ago
Closed 17 years ago
Use -z defs when linking on linux
Categories
(Firefox Build System :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
(Keywords: fixed1.8.1)
Attachments
(4 files, 2 obsolete files)
1.98 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
2.42 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
7.30 KB,
patch
|
benjamin
:
review+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
659 bytes,
patch
|
Details | Diff | Splinter Review |
-z defs (or its equivalent --no-undefined) disallows undefined symbols when creating .so files, so that this problem can be caught at compile time rather than runtime. the attached patch makes the build process use it.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #218096 -
Flags: review?(benjamin)
Assignee | ||
Updated•17 years ago
|
Attachment #218096 -
Flags: approval-branch-1.8.1?(benjamin)
Comment 2•17 years ago
|
||
Comment on attachment 218096 [details] [diff] [review] patch Why aren't we adding this flag to, say, DSO_LDOPTS?
Comment 3•17 years ago
|
||
Comment on attachment 218096 [details] [diff] [review] patch I think that munging DSO_LDOPTS is the correct solution.
Attachment #218096 -
Flags: review?(benjamin)
Attachment #218096 -
Flags: review-
Attachment #218096 -
Flags: approval-branch-1.8.1?(benjamin)
Assignee | ||
Comment 4•17 years ago
|
||
this is needed too - various modules were missing libraries in their linking list, which is fatal with -z defs.
Attachment #219049 -
Flags: review?(benjamin)
Updated•17 years ago
|
Attachment #219049 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 5•17 years ago
|
||
Comment on attachment 219049 [details] [diff] [review] add missing libraries (checked in) Checking in gfx/src/thebes/Makefile.in; /cvsroot/mozilla/gfx/src/thebes/Makefile.in,v <-- Makefile.in new revision: 1.16; previous revision: 1.15 done Checking in gfx/thebes/src/Makefile.in; /cvsroot/mozilla/gfx/thebes/src/Makefile.in,v <-- Makefile.in new revision: 1.25; previous revision: 1.24 done Checking in toolkit/components/gnome/Makefile.in; /cvsroot/mozilla/toolkit/components/gnome/Makefile.in,v <-- Makefile.in new revision: 1.6; previous revision: 1.5 done
Attachment #219049 -
Attachment description: add missing libraries → add missing libraries (checked in)
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 219049 [details] [diff] [review] add missing libraries (checked in) I want both of these patches on the branch if possible, so requesting approval for this one.-
Attachment #219049 -
Flags: approval-branch-1.8.1?(benjamin)
Assignee | ||
Comment 7•17 years ago
|
||
Comment on attachment 219049 [details] [diff] [review] add missing libraries (checked in) er, nevermind, this patch doesn't apply to that branch
Attachment #219049 -
Flags: approval-branch-1.8.1?(benjamin)
Assignee | ||
Comment 8•17 years ago
|
||
now in DSO_LDOPTS note: I can't test the solaris changes here; I'll back them out should the solaris tinderboxes go red.
Attachment #218096 -
Attachment is obsolete: true
Attachment #219079 -
Flags: review?(benjamin)
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8.1
Updated•17 years ago
|
Attachment #219079 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 9•17 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1660; previous revision: 1.1659 done
Assignee | ||
Comment 10•17 years ago
|
||
ok, solaris did go red with a bustage I don't quite understand (apparently it didn't link to libc?), so I backed out the solaris changes. I filed Bug 335112 though (anyone know a solaris person to cc there?) There was other bustage as well: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/build&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.140&rev2=1.141&root=/cvsroot http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/library&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.36&rev2=1.37&root=/cvsroot
Assignee | ||
Comment 11•17 years ago
|
||
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/build&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.141&rev2=1.142&root=/cvsroot
![]() |
||
Comment 12•17 years ago
|
||
Is the thunderbird bustage I get: ../../../../mozilla/mail/components/shell/nsMailGNOMEIntegration.cpp:112: undefined reference to `g_filename_from_utf8' etc. a result of this checkin?
Assignee | ||
Comment 13•17 years ago
|
||
yes. should be fixed now: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mail/components/build&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.10&rev2=1.11&root=/cvsroot (makes this match a similar block in browser/components/build/Makefile.in)
Comment 14•17 years ago
|
||
jprof bustage: ...mozilla/tools/jprof/stub/libmalloc.c:148:undefined reference to _r_debug (_r_debug appears to be exported by libc.a)
Assignee | ||
Comment 15•17 years ago
|
||
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/library&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.37&rev2=1.38&root=/cvsroot (for a different MOZ_JPROF bustage)
Assignee | ||
Comment 16•17 years ago
|
||
(In reply to comment #14) > (_r_debug appears to be exported by libc.a) turns out that the dynamic library this is in is actually /lib/ld-linux.so.2...
Assignee | ||
Comment 17•17 years ago
|
||
Attachment #225738 -
Flags: review?(benjamin)
Attachment #225738 -
Flags: approval-branch-1.8.1?(benjamin)
Assignee | ||
Comment 18•17 years ago
|
||
the previous version was missing a few fixes
Attachment #225738 -
Attachment is obsolete: true
Attachment #225784 -
Flags: review?(benjamin)
Attachment #225784 -
Flags: approval-branch-1.8.1?(benjamin)
Attachment #225738 -
Flags: review?(benjamin)
Attachment #225738 -
Flags: approval-branch-1.8.1?(benjamin)
Updated•17 years ago
|
Attachment #225784 -
Flags: review?(benjamin)
Attachment #225784 -
Flags: review+
Attachment #225784 -
Flags: approval-branch-1.8.1?(benjamin)
Attachment #225784 -
Flags: approval-branch-1.8.1+
Assignee | ||
Comment 19•17 years ago
|
||
needed for gtk1 w/ SVG
Assignee | ||
Comment 20•17 years ago
|
||
please file a new bug on comment 14/comment 16 checked in on MOZILLA_1_8_BRANCH (both patches)
Assignee | ||
Comment 21•17 years ago
|
||
another bustage fix (static builds w/ jprof) http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=mozilla/webshell/tests/viewer/Attic&command=DIFF_FRAMESET&rev1=1.184&rev2=1.184.2.1
Updated•5 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•