333640 - Use -z defs when linking on linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

-z defs (or its equivalent --no-undefined) disallows undefined symbols when creating .so files, so that this problem can be caught at compile time rather than runtime.

the attached patch makes the build process use it.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 218096 [details] [diff] [review]
patch

Why aren't we adding this flag to, say, DSO_LDOPTS?

Comment 3

[Benjamin Smedberg]

Comment on attachment 218096 [details] [diff] [review]
patch

I think that munging DSO_LDOPTS is the correct solution.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: add missing libraries (checked in)

this is needed too - various modules were missing libraries in their linking list, which is fatal with -z defs.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 219049 [details] [diff] [review]
add missing libraries (checked in)

Checking in gfx/src/thebes/Makefile.in;
/cvsroot/mozilla/gfx/src/thebes/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
Checking in gfx/thebes/src/Makefile.in;
/cvsroot/mozilla/gfx/thebes/src/Makefile.in,v  <--  Makefile.in
new revision: 1.25; previous revision: 1.24
done
Checking in toolkit/components/gnome/Makefile.in;
/cvsroot/mozilla/toolkit/components/gnome/Makefile.in,v  <--  Makefile.in
new revision: 1.6; previous revision: 1.5
done

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 219049 [details] [diff] [review]
add missing libraries (checked in)

I want both of these patches on the branch if possible, so requesting approval for this one.-

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 219049 [details] [diff] [review]
add missing libraries (checked in)

er, nevermind, this patch doesn't apply to that branch

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

now in DSO_LDOPTS

note: I can't test the solaris changes here; I'll back them out should the solaris tinderboxes go red.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1660; previous revision: 1.1659
done

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, solaris did go red with a bustage I don't quite understand (apparently it didn't link to libc?), so I backed out the solaris changes. I filed Bug 335112 though (anyone know a solaris person to cc there?)

There was other bustage as well:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/build&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.140&rev2=1.141&root=/cvsroot
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/library&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.36&rev2=1.37&root=/cvsroot

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/build&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.141&rev2=1.142&root=/cvsroot

Comment 12

[Boris Zbarsky [:bzbarsky]]

Is the thunderbird bustage I get:

../../../../mozilla/mail/components/shell/nsMailGNOMEIntegration.cpp:112: undefined reference to `g_filename_from_utf8'

etc.

a result of this checkin?

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

yes. should be fixed now:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mail/components/build&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.10&rev2=1.11&root=/cvsroot
(makes this match a similar block in browser/components/build/Makefile.in)

Comment 14

[[e-mail]]

jprof bustage:
...mozilla/tools/jprof/stub/libmalloc.c:148:undefined reference to _r_debug

(_r_debug appears to be exported by libc.a)

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/library&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.37&rev2=1.38&root=/cvsroot
(for a different MOZ_JPROF bustage)

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #14)
> (_r_debug appears to be exported by libc.a)

turns out that the dynamic library this is in is actually /lib/ld-linux.so.2...

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch for 1_8_BRANCH

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch for 1_8_BRANCH, v2

the previous version was missing a few fixes

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: additional patch for 1_8_BRANCH

needed for gtk1 w/ SVG

Comment 20

[Christian :Biesinger (don't email me, ping me on IRC)]

please file a new bug on comment 14/comment 16

checked in on MOZILLA_1_8_BRANCH (both patches)

Comment 21

[Christian :Biesinger (don't email me, ping me on IRC)]

another bustage fix (static builds w/ jprof)
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=mozilla/webshell/tests/viewer/Attic&command=DIFF_FRAMESET&rev1=1.184&rev2=1.184.2.1