333651 - URL bar doesn't get focus when opening a new tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Noa Groveman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8) Gecko/20060411 Firefox/2.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8) Gecko/20060411 Firefox/2.0a1

When opening a new tab the URL bar doesn't get focus like it should.. this only happens when opening a new tab, not when opening a new window

Reproducible: Always

Steps to Reproduce:
1. open new tab
2. try to type in URL
3. realize that the URL bar isn't in focus

Comment 1

[Peter van der Woude [:Peter6]]

branch-only

regressed between 20060410 and 20060411

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Seeing this in the JS Console when using Ctrl+T or when switching between tabs, also occuring in 'Safe Mode' 

Error: BrowserController.onTabSwitch is not a function
Source file: chrome://browser/content/browser.xul
Line: 1

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060411 Firefox/2.0a1 ID:2006041103

Comment 3

[Steffen Wilberg]

This was caused by the checkin for bug 329733, which removed onTabSwitch on the branch.

Compare:
Trunk:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.xul&rev=1.295&mark=476#466
Branch:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.xul&rev=1.268.2.30&mark=476#466

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

With today's build, now I'm seeing XML errors in the JS Console: 
Warning: Event=popupshowing, use of preventBubble() is deprecated. Use W3C standard stopPropagation() instead.
Source file: chrome://browser/content/browser.xul

Along with the error reported yesterday:
Error: BrowserController.onTabSwitch is not a function
Source file: chrome://browser/content/browser.xul
Line: 1



Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060412 Firefox/2.0a1 ID:2006041204

Comment 5

[Steffen Wilberg]

Jim, that's not related to this bug and is probably caused by an extension since we don't use preventBubble anymore (bug 330710): http://lxr.mozilla.org/mozilla1.8/search?string=preventBubble

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to comment #5)
> Jim, that's not related to this bug and is probably caused by an extension
> since we don't use preventBubble anymore (bug 330710):
> http://lxr.mozilla.org/mozilla1.8/search?string=preventBubble
> 

Sorry, TabMix Plus dev version 0.3.0.604 causing the errors in XML, strange I did not see them yesterday.  I will file a report with the author.

Comment 7

[Steffen Wilberg]

Attachment: patch

One-liner, merges trunk to branch.

Comment 8

[Doug Halamay]

I can verify that the patch fixes the problem.  I just did a new build with the patch included, and everything is back to normal...including the problem of the bookmark menu staying open when middle-clicking an entry to open a bookmark in a new tab.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 333804 has been marked as a duplicate of this bug. ***

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 218197 [details] [diff] [review]
patch

r+a=[e-mail]

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Looks like this is already in the trunk, can you check in on the branch asap? Thanks for the quick help!

Comment 12

[Steffen Wilberg]

Checked in on branch.

Comment 13

[Dave Townsend [:mossop]]

*** Bug 333956 has been marked as a duplicate of this bug. ***

Comment 14

[Tracy Walker [:tracy]]

Verified with Windows and Mac 2.0b1rc3 builds