Closed Bug 333666 Opened 14 years ago Closed 14 years ago

Returning uninitialized rv from XULSortServiceImpl::GetNodeValue

Categories

(Core :: XUL, defect, major)

defect
Not set
major

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jwatt, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

 
Attached patch patchSplinter Review
Attachment #218121 - Flags: superreview?(bzbarsky)
Attachment #218121 - Flags: review?(bzbarsky)
Comment on attachment 218121 [details] [diff] [review]
patch

I'd like Neil to review this (in particular, should that be RFD_NO_VALUE?)
Attachment #218121 - Flags: review?(bzbarsky) → review?(enndeakin)
Flags: blocking1.9a1?
Comment on attachment 218121 [details] [diff] [review]
patch

I'm currently significantly reworking the sort service so the code in question won't exist after that. No callers actually check the return value from GetNodeValue anyway, so there isn't any priority in changing this.
Attachment #218121 - Flags: superreview?(bzbarsky)
Attachment #218121 - Flags: review?(enndeakin)
Assignee: jwatt → xptoolkit.xul
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Flags: blocking1.9a1?
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.