Closed
Bug 333668
Opened 19 years ago
Closed 18 years ago
Dereferencing uninitialized lastnode in nsXULTemplateQueryProcessorRDF::CompileQuery
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Assigned: enndeakin)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
1.35 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
If mSimpleRuleMemberTest evaluates to true we'll end up with |lastnode| being a dangling pointer.
![]() |
Reporter | |
Comment 1•19 years ago
|
||
Oh, and we'll do NS_FAILED(rv) on an uninitialized rv.
![]() |
||
Updated•19 years ago
|
Flags: blocking1.9a1?
![]() |
Reporter | |
Updated•19 years ago
|
Assignee: jwatt → nobody
Assignee | ||
Comment 2•18 years ago
|
||
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #237139 -
Flags: superreview?(bugmail)
Attachment #237139 -
Flags: review?(bugmail)
Comment on attachment 237139 [details] [diff] [review]
Add asserttion and return an error
Please also initialize |lastnode| to nsnull. It's not going to cost anything and is more future-proof
Attachment #237139 -
Flags: superreview?(bugmail)
Attachment #237139 -
Flags: superreview+
Attachment #237139 -
Flags: review?(bugmail)
Attachment #237139 -
Flags: review+
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
![]() |
||
Updated•18 years ago
|
Flags: blocking1.9a1?
Assignee | ||
Updated•17 years ago
|
Flags: in-testsuite-
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•