Closed Bug 333821 Opened 18 years ago Closed 16 years ago

Capital (uppercase) J cannot be typed when entering text in some fields in Thunderbird

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mapsd2000, Assigned: philor)

References

Details

(Keywords: verified1.8.1.12)

Attachments

(1 file)

Branch fix v.1
1.57 KB, patch
mscott
: superreview+
dveditz
: approval1.8.1.12+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/418 (KHTML, like Gecko) Safari/417.9.2
Build Identifier: version 1.5 (20051201)

When viewing an email in the preview pane, every email address in the message header area becomes a contextual menu when clicked. One of the menu options is Add to Address Book. Typically, the First and Last name fields are blank in the dialog that appears to add a new card to the address book.  Typing a capital "J" will make the Message menu flash for an instant and no J will appear.  Typing a name like "John"  in the First name field is impossible, and a copy-and-paste like action must be used instead.  There seems to be a conflict with the Shift-J keyboard shortcut to mark as message as junk, even though the add new address book card dialog is active.  A workaround is to remap the mark as junk keyboard shortcut to something else like command-J using the Keyconfig extension.

Reproducible: Always

Steps to Reproduce:
1. Choose Add to Address Book from the contextual menu of email address in header section of message preview
2. Type a capital (uppercase) "J" in the First Name field
3.

Actual Results:  
Message menu in menubar flashes for an instant.  No letter "J" appears.

Expected Results:  
A letter "J" would appear as typed.
FWIW: WFM with SeaMonkey trunk 2006-06-10 on MacOSX 10.4.6.
This same problem appears in other text fields.

When writing in many fields (i.e. labeling a new folder, searching for 
something, filling out address book, etc...) typing a capital "j" runs the not junk shortcut from 
the tools menu.

The workaround I have developed is to hold down shift + "j" and the key 
repeat is not registered as a shortcut, then delete unwanted capital "j"s. Yes this sucks...


Atm the only way to cure this is to remove the Shift+J shortcut from the menu (not the command itself). See bug 195979 for the underlying issue. The workaround for thunderbird in bug 199019 didn't covered Shift+J. The reason that it works in seamonkey is that we also removed the Shift+J combo from the menu (bug 194147)
Based on previous comments this is a general thunderbird bug, therefore reassigning component and updating summary.
Component: Address Book → General
Depends on: 199019
QA Contact: address-book → general
Summary: Capital (uppercase) J cannot be typed when adding card to address book from contextual menu of email address in message header section of preview → Capital (uppercase) J cannot be typed when entering text in some fields in Thunderbird
Confirming. I'm curious as to whether this bug occurs with Cocoa widgets (you'd need to test with Thunderbird trunk to see). If it is, then we should probably let this bug be, but if it's not, I think removing this shortcut would be appropriate.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 2.0
If it helps, I have found that the error only occurs when the 'Message' menu is active.
(In reply to comment #6)
> Confirming. I'm curious as to whether this bug occurs with Cocoa widgets (you'd
> need to test with Thunderbird trunk to see). If it is, then we should probably
> let this bug be, but if it's not, I think removing this shortcut would be
> appropriate.
> 

It does looks like Cocoa widgets fixed this. I can type a capital J in the search field or following the str in comment #0 in a recent trunk build (10.4.10).
Attached patch Branch fix v.1 — — Splinter Review 
Branch only; I'm beginning to have faith that Widget: Cocoa is going to continue to work, so I'm looking at putting them back in on the trunk once I find the appropriate bug. However, I'm getting tired of having to track this bug down to dupe to it, and it strikes me as branch-safe to get rid of this last remaining one.
Assignee: mscott → philringnalda
Status: NEW → ASSIGNED
Attachment #287649 - Flags: superreview?(mscott)
Attachment #287649 - Flags: approval1.8.1.10?
Comment on attachment 287649 [details] [diff] [review]
Branch fix v.1

next TB is 1.8.1.11
Attachment #287649 - Flags: approval1.8.1.10? → approval1.8.1.11?
Comment on attachment 287649 [details] [diff] [review]
Branch fix v.1

Probably save flag churn if I just wait until after I've got review, like I'm supposed to.
Attachment #287649 - Flags: approval1.8.1.11?
Comment on attachment 287649 [details] [diff] [review]
Branch fix v.1

not sure how we missed this one when we fixed the rest of them....
Attachment #287649 - Flags: superreview?(mscott) → superreview+
Attachment #287649 - Flags: approval1.8.1.11?
Comment on attachment 287649 [details] [diff] [review]
Branch fix v.1

approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #287649 - Flags: approval1.8.1.12? → approval1.8.1.12+
mail/base/content/mailWindowOverlay.xul 1.116.2.81
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
I have Thunderbird 2, which is the current version, I think. What good is fixing this in 1.8? How do I get a fix for 2.0?
1.8.1.12 isn't a Thunderbird version, it's a Gecko version. Fx 2.0.0.x and Tb 2.0.0.x are both built off 1.8.1.x, so the next Thunderbird 2.0.0.x release, which will be 2.0.0.12 if nothing intervenes, will have this included.
I cannot reproduce this problem with Thunderbird 2.0.0.9 (or the rc1 of 2.0.0.12) on my intel Mac running OS X 10.5. Shift-J always gives an upper case 'j' in the dialog in question.

Are there better steps?
The key is to make sure you have a message selected, so that the Message - Mark as - Junk/Not Junk menuitem isn't disabled. I don't really remember with the addressbook, but with the filter dialog I remember it being easier to hit the bad state by opening the filter dialog, going back to the three-pane window and selecting the message again, and then refocusing the filter dialog. It seems like select a message, then right click a (renameable, not Inbox or Junk) folder, Rename was one of the easiest to consistently hit.

If the selected message is not marked as junk try to type a lowercase j or if it is marked as junk try to type Shift+j - it's much more fun when you hit the bug to hit it with the key that actually changes the junk status of your message, instead of just flashing the menu without doing anything.
Where I run into it most is trying to create a new folder in the account/folder tree view.
It was still there for me in 2.0.0.9 on My MacPro (leopard). I just followed the instructions in the first post and was unable to enter a J.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This says fixed1.8.1.12, you will need thunderbird 2.0.0.12 to have the fix.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
where do I get that?
Actually, if you want to verify this bug, you shouldn't use the nightly. We've forked for the release. Use ftp://ftp.mozilla.org/pub/thunderbird/nightly/2.0.0.12-candidates/rc1/
I am on 2.0.0.13pre and it is fixed on the Mac
Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.12) Gecko/2008021304 Thunderbird/2.0.0.12.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.12 → verified1.8.1.12
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: