333860 - When starting offline, Compatibility Wizard should not be checking for updates

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Cowperthwaite]

When running a version of Firefox (or Thunderbird) different from the previously-run version, and starting up offline (more common with TB, maybe), the Extension Compatibility Update wizard starts up and immediately starts accessing the network.  If the user has gone to the effort of starting in offline mode, the wizard should abide by this preference.  Extensions can still be enabled/disabled according to the local copies of the install.rdf files.

Note that if the network is actually disconnected, the wizard will display "Checking..." for an indeterminite amount of time -- I haven't see it time out after several minutes.  In this case, clicking Cancel will close the wizard and the program will open.

Comment 1

[Robert Strong (they/them - no direct email)]

I will probably fix this bug in bug 310745

Comment 2

[Adam Guthrie]

Mike, any word on whether the bug Robert mentioned fixed this?

Comment 3

[Robert Strong (they/them - no direct email)]

It didn't... there were other serious problems with the wizard - see bug 342606

Comment 4

[Dave Townsend [:mossop]]

Attachment: Screenshot of proposed behaviour

The patch I have displays this as the first page of the update compatibility checker if the app appears to be offline.

The checkbox is initially unchecked but maybe that should default to checked to encourage checking for updates?

When the checkbox is ticked the next button will be enabled and clicking it will start the compatibility check.

Cancel of course cancels the checking.

Mike, can you take a speedy look over and I'm sure you have better strings to suggest than me.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229714 [details]
Screenshot of proposed behaviour

We'd want this screen only when the user needs to be online, not before. If the extensions are all compatible out of the box, presumably we wouldn't see this, right?

Once we do see this screen, though, we should be consistent with bug 342606 in calling these compatibility updates, so:

"Minefield needs to go online in order to see if updates are available for your add-ons to make them compatible with this version.

 [ ] Go online now"

Comment 6

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
> (From update of attachment 229714 [details] [edit])
> We'd want this screen only when the user needs to be online, not before. If the
> extensions are all compatible out of the box, presumably we wouldn't see this,
> right?
We only show the wizard when we have extensions installed that are not app managed and we always sync minVersion and maxVersion info so this should always be shown if offline.

Comment 7

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This adds the extra page to the wizard to it and switches to it at startup if the app appears to be offline.

The checkbox starts enabled and toggling it toggles the disabled state of the next button.

On proceeding the app is set online.

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 229730 [details] [diff] [review]
patch rev 1

Looks good and thanks!

Comment 9

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 229730 [details] [diff] [review]
patch rev 1

Requesting 1.8.1 - I've tested this with both Firefox and Thunderbird and with this patch we now do the right thing when starting up offline

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 229730 [details] [diff] [review]
patch rev 1

a=mconnor on behalf of drivers

Comment 12

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH

Comment 13

[Mike Cowperthwaite]

V with TB 2a1-0724, 3a1-0806, Win2K.
Thanks, Dave Townsend!  Nice solution.

Comment 14

[Mike Cowperthwaite]

Really V now.