When starting offline, Compatibility Wizard should not be checking for updates

VERIFIED FIXED in mozilla1.8.1beta2

Status

()

--
minor
VERIFIED FIXED
13 years ago
10 years ago

People

(Reporter: mcow, Assigned: mossop)

Tracking

({fixed1.8.1, late-l10n})

1.8 Branch
mozilla1.8.1beta2
fixed1.8.1, late-l10n
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

13 years ago
When running a version of Firefox (or Thunderbird) different from the previously-run version, and starting up offline (more common with TB, maybe), the Extension Compatibility Update wizard starts up and immediately starts accessing the network.  If the user has gone to the effort of starting in offline mode, the wizard should abide by this preference.  Extensions can still be enabled/disabled according to the local copies of the install.rdf files.

Note that if the network is actually disconnected, the wizard will display "Checking..." for an indeterminite amount of time -- I haven't see it time out after several minutes.  In this case, clicking Cancel will close the wizard and the program will open.
I will probably fix this bug in bug 310745
Depends on: 310745
Target Milestone: --- → Firefox 2 beta1

Updated

12 years ago
Flags: blocking-firefox2+
Assignee: robert.bugzilla → nobody
(Assignee)

Updated

12 years ago
Assignee: nobody → mossop.bugzilla
Version: Trunk → 2.0 Branch

Updated

12 years ago
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2

Comment 2

12 years ago
Mike, any word on whether the bug Robert mentioned fixed this?
It didn't... there were other serious problems with the wizard - see bug 342606

Updated

12 years ago
Whiteboard: .5d → .5d [at risk]
(Assignee)

Updated

12 years ago
Whiteboard: .5d [at risk] → .5d [at risk] ETA 07/22
(Assignee)

Comment 4

12 years ago
Created attachment 229714 [details]
Screenshot of proposed behaviour

The patch I have displays this as the first page of the update compatibility checker if the app appears to be offline.

The checkbox is initially unchecked but maybe that should default to checked to encourage checking for updates?

When the checkbox is ticked the next button will be enabled and clicking it will start the compatibility check.

Cancel of course cancels the checking.

Mike, can you take a speedy look over and I'm sure you have better strings to suggest than me.
Attachment #229714 - Flags: ui-review?
Comment on attachment 229714 [details]
Screenshot of proposed behaviour

We'd want this screen only when the user needs to be online, not before. If the extensions are all compatible out of the box, presumably we wouldn't see this, right?

Once we do see this screen, though, we should be consistent with bug 342606 in calling these compatibility updates, so:

"Minefield needs to go online in order to see if updates are available for your add-ons to make them compatible with this version.

 [ ] Go online now"
Attachment #229714 - Flags: ui-review? → ui-review+
(In reply to comment #5)
> (From update of attachment 229714 [details] [edit])
> We'd want this screen only when the user needs to be online, not before. If the
> extensions are all compatible out of the box, presumably we wouldn't see this,
> right?
We only show the wizard when we have extensions installed that are not app managed and we always sync minVersion and maxVersion info so this should always be shown if offline.
(Assignee)

Comment 7

12 years ago
Created attachment 229730 [details] [diff] [review]
patch rev 1

This adds the extra page to the wizard to it and switches to it at startup if the app appears to be offline.

The checkbox starts enabled and toggling it toggles the disabled state of the next button.

On proceeding the app is set online.
Attachment #229730 - Flags: review?(robert.bugzilla)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Comment on attachment 229730 [details] [diff] [review]
patch rev 1

Looks good and thanks!
Attachment #229730 - Flags: review?(robert.bugzilla) → review+
Checked in to trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: .5d [at risk] ETA 07/22
Comment on attachment 229730 [details] [diff] [review]
patch rev 1

Requesting 1.8.1 - I've tested this with both Firefox and Thunderbird and with this patch we now do the right thing when starting up offline
Attachment #229730 - Flags: approval1.8.1?
Keywords: late-l10n
Comment on attachment 229730 [details] [diff] [review]
patch rev 1

a=mconnor on behalf of drivers
Attachment #229730 - Flags: approval1.8.1? → approval1.8.1+
Checked in to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
(Reporter)

Comment 13

12 years ago
V with TB 2a1-0724, 3a1-0806, Win2K.
Thanks, Dave Townsend!  Nice solution.
(Reporter)

Comment 14

12 years ago
Really V now.
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.