333863 - [Mac] Places is buggy in non browser windows

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Currently, Places almost does not work in non-browser window (or when no window is open) on Mac.

I'm attaching several issues, but nore there's still some work to do here...

Comment 1

[Asaf Romano (gone)]

Make that:
"I'm attaching a fix for several issues, but note there's still some work to do here...

Comment 2

[Annie Sullivan]

Is bug 331123 a dupe of this (a subset of this problem) or a separate bug?

Comment 3

[Asaf Romano (gone)]

Attachment: first patch

Includes:
 1. Make it so the bookmarks menu isn't empty
 2. Avoid redeclaration of a constant in macWindowMenu.js
 3. Don't assume there's a webnavigation object when opening the history menu

The bookmark menu items seem to work on second access only, but i think this can be fixed by porting back josh's "Open In Tabs" fix to the branch.

Comment 4

[Asaf Romano (gone)]

*** Bug 331123 has been marked as a duplicate of this bug. ***

Comment 5

[Asaf Romano (gone)]

Attachment: first patch, again

Comment 6

[Asaf Romano (gone)]

Comment on attachment 218297 [details] [diff] [review]
first patch, again

carrying over r=.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 218297 [details] [diff] [review]
first patch, again

sr=[e-mail]

Comment 8

[Asaf Romano (gone)]

Attachment: first patch, as checked in

I forgot to add the browser/global/skin stylesheets in the previous patches.

Comment 9

[Asaf Romano (gone)]

The patch for bug 329337 is now on the branch.

Remaining issues are mainly related to Open In Tabs/Bookmark All Tabs, going to open new bugs for those.

-> fixed.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv