333864 - Non-localizable label in Places popup: "Search:"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[u60234]

Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.9a1) Gecko/20060413 Firefox/3.0a1

The label for the Places popup search box is hardcoded at
http://lxr.mozilla.org/mozilla/source/browser/components/places/content/placesPopup.xul#65

> <label value="Search:"/>

Comment 1

[Joey Minta]

Attachment: add dtd and use entity

Patch adds the places.dtd to the xul file so that we can use the search.label entity.

Comment 2

[Joey Minta]

Comment on attachment 220358 [details] [diff] [review]
add dtd and use entity

I'm unfamiliar with the Places development flow.  What, if any, additional reviews/approvals do I need here prior to checking in?  Do Places patches still go to both the 1.8 branch and trunk or just trunk?

Comment 3

[Joey Minta]

Comment on attachment 220358 [details] [diff] [review]
add dtd and use entity

Heh, guess this bug has been sitting here a bit.  mconnor, I assume even though we're not building places on 1_8, we still want to keep them in sync?

Comment 4

[Brett Wilson]

Branch and trunk for places are currently a bit out of sync. Feel free to check into branch if it's convenient, but don't worry too much about it.

Comment 5

[Joey Minta]

Patch landed on branch and trunk.
Checking in browser/components/places/content/placesPopup.xul;
/cvsroot/mozilla/browser/components/places/content/placesPopup.xul,v  <--  placesPopup.xul
new revision: 1.1.2.3; previous revision: 1.1.2.2

Checking in browser/components/places/content/placesPopup.xul;
/cvsroot/mozilla/browser/components/places/content/placesPopup.xul,v  <--  placesPopup.xul
new revision: 1.2; previous revision: 1.1

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 220358 [details] [diff] [review]
add dtd and use entity

not that it matters!

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv