bug 270893 broke building of the Spatial Navigation extension

RESOLVED WORKSFORME

Status

()

Firefox
Build Config
RESOLVED WORKSFORME
12 years ago
12 years ago

People

(Reporter: Roy Tam, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

915 bytes, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060411 Firefox/1.5.0.2 (Firefox musume)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060411 Firefox/1.5.0.2 (Firefox musume)

Got compilation error after cvs checkout ( http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=mozilla%2F&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-12+08%3A32&maxdate=2006-04-12+08%3A43&cvsroot=%2Fcvsroot ):
c:\moztrunk\mozilla\extensions\spatialnavigation\src\nsSpatialNavigationPrivate.h(49) : fatal error C1083: Cannot open include file: 'nsArray.h': No such file or directory
make[6]: *** [nsSpatialNavigationService.obj] Error 2

Reproducible: Always

Steps to Reproduce:
1.checkout from cvs
2.add "ac_add_options --enable-extensions=spatialnavigation" to .mozconfig
3.compile

Actual Results:  
Compilation failed with nsSpatialNavigationPrivate.h
c:\moztrunk\mozilla\extensions\spatialnavigation\src\nsSpatialNavigationPrivate.h(49) : fatal error C1083: Cannot open include file: 'nsArray.h': No such file or directory
make[6]: *** [nsSpatialNavigationService.obj] Error 2

Expected Results:  
Compiled successfully without any error.

This cause minimo can't be built.

Comment 1

12 years ago
Created attachment 218416 [details] [diff] [review]
v1 

Remove unused nsArray include.
Attachment #218416 - Flags: review?(benjamin)

Updated

12 years ago
Attachment #218416 - Flags: review?(benjamin) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: "Freeze nsIArray (requires separating nsIMutableArray into another .idl file); also removes NS_NewArray and moves do_QueryElementAt into the glue" cause Spatial Navigation extension can not be built → bug 270893 broke building of the Spatial Navigation extension

Comment 2

12 years ago
Was fixed as a part of another bug.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.