333930 - Error in SanitizeListener() due to <menuitem id="sanitizeItem"> not being defined in --disable-places

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[:Mook]

(--disable-places only)

<menuitem id="sanitizeItem"/> now only exist #ifdef MOZ_PLACES which breaks the SanitizeListener() (causing delayedStartup to break).

Patch coming.

Comment 1

[:Mook]

Attachment: patch #ifndef MOZ_PLACES

Comment 2

[:Mook]

Comment on attachment 218371 [details] [diff] [review]
patch #ifndef MOZ_PLACES

Gavin suggested that I ask Ben for r instead.

(This basically undoes the change linked in the URL, but only for --disable-places - the code moved into a #ifdef MOZ_PLACES block)

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 218371 [details] [diff] [review]
patch #ifndef MOZ_PLACES

r=[e-mail]

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser-menubar.inc 	1.87
mozilla/browser/base/content/browser-menubar.inc 	1.57.2.27

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv