Dragging/dropping an item in Bookmarks Manager almost hangs the browser when the item is in the middle of a large bookmark database

RESOLVED WORKSFORME

Status

()

Firefox
Bookmarks & History
P3
normal
RESOLVED WORKSFORME
11 years ago
8 years ago

People

(Reporter: Ryuichi KUBUKI, Unassigned)

Tracking

({perf})

Trunk
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060414 Firefox/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060414 Firefox/3.0a1

Dragging/dropping an item to move it in Bookmarks Menu almost hangs the browser when the item is in the middle of a large database. My bookmarks_history.sqlite is 20MB.

If I move an item near the end of the menu there's no problem, but if it's in the middle or up it freezes all FF windows for at least 5 seconds. This build is non-Cairo trunk without an extension.

Reproducible: Always
(Reporter)

Updated

11 years ago
Keywords: perf
Assignee: nobody → bugs
Priority: -- → P3
Target Milestone: --- → Firefox 2 beta1
(Reporter)

Comment 1

11 years ago
Cut & paste is smooth while drag & drop is unusually slow.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060528 Minefield/3.0a1
Summary: Dragging/droppping an item in Bookmarks Menu almost hangs the browser when the item is in the middle of a large database → Dragging/dropping an item in Bookmarks Menu almost hangs the browser when the item is in the middle of a large bookmark database
Assignee: bugs → nobody
(Reporter)

Comment 2

10 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre ID:2007052103 [cairo]

places.sqlite is 14,534KB and drag/drop of an item took 100% for one of 2.5Ghz cores in my CPU.
Target Milestone: Firefox 2 beta1 → ---
right now dnd of items to the bookmarks menu is broken, but when it returns, this perf bug might be valid, so tracking it.

KL, are you dropping into the menus, or the tree?  (If the tree, see bug #381593)
Blocks: 380307
(Reporter)

Comment 4

10 years ago
(In reply to comment #3)
> right now dnd of items to the bookmarks menu is broken, but when it returns,
> this perf bug might be valid, so tracking it.
> 
> KL, are you dropping into the menus, or the tree?  (If the tree, see bug
> #381593)
> 

I thought I edited but it's Bookmarks Manager not menu, sorry for inconvenience
It works OK in the sidebar for perf BTW.
Summary: Dragging/dropping an item in Bookmarks Menu almost hangs the browser when the item is in the middle of a large bookmark database → Dragging/dropping an item in Bookmarks Manager almost hangs the browser when the item is in the middle of a large bookmark database
(Reporter)

Comment 5

10 years ago
I stand corrected, it freezes in the side bar too.

(In reply to comment #4)
> (In reply to comment #3)
> > right now dnd of items to the bookmarks menu is broken, but when it returns,
> > this perf bug might be valid, so tracking it.
> > 
> > KL, are you dropping into the menus, or the tree?  (If the tree, see bug
> > #381593)
> > 
> 
> I thought I edited but it's Bookmarks Manager not menu, sorry for inconvenience
> It works OK in the sidebar for perf BTW.
> 

KL, for the sidebar freeze, that is also a tree.  (See bug #381593)
(Reporter)

Comment 7

10 years ago
WFM now on

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070628 Minefield/3.0a6pre ID:2007062807 [cairo]
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WORKSFORME
KL, if you were seeing bug #381593, I am still able to reproduce that.
(Reporter)

Comment 9

10 years ago
(In reply to comment #8)
> KL, if you were seeing bug #381593, I am still able to reproduce that.
> 

You mean dropping an item at the bottom unlike in the middle of many bookmark items? Right now everything works fine for me.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070628 Minefield/3.0a6pre ID:2007062813 [cairo]
(Reporter)

Updated

10 years ago
Blocks: 395528
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.