334091 - [mac] "Search History" key is mapped to old open-history-sidebar command in Places builds

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

On OS X, the "Seatch History" key is mapped to the old open-history-sidebar command in Places builds.

Also, the keyboard shortcut isn't visible in the History menu, this is an all/all bug, unless there's some overlay magic somewhere - no windows box to test on at the moment ;)

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 218506 [details] [diff] [review]
patch

sr=[e-mail]

Comment 3

[Asaf Romano (gone)]

Branch:
Checking in browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <--  browser-menubar.inc
new revision: 1.57.2.28; previous revision: 1.57.2.27
done
Checking in browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.51.2.22; previous revision: 1.51.2.21
done

Trunk:
Checking in browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <--  browser-menubar.inc
new revision: 1.88; previous revision: 1.87
done
Checking in browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.75; previous revision: 1.74
done

Comment 4

[Steffen Wilberg]

So the "Search in History" menu item still opens the Places Organizer (command="Browser:SearchHistory" -> showPlacesSearch -> showPlacesOrganizer),
whereas the key displayed next to it (Ctrl+H) opens the Places Popup (command="viewHistoryPlaces" -> showPlacesPopup).

I guess the menu item should open the Places Popup as well.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv