Closed Bug 334189 Opened 14 years ago Closed 14 years ago

nsSHistory::PrintHistory should use a string class

Categories

(Core :: DOM: Navigation, defect)

PowerPC
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, helpwanted)

Attachments

(1 obsolete file)

This code is deleting an uninitialized variable often. coverity tried to complain about this code, but in my book it failed so no credit to coverity for this bad code.

note that this code is debug, so it's not severe.
Component: Embedding: Docshell → History: Session
Keywords: helpwanted
QA Contact: docshell → history.session
ok, one of the other coverity reports did complain about this.
Keywords: coverity
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #218648 - Flags: superreview?(jag)
Attachment #218648 - Flags: review?(jag)
Comment on attachment 218648 [details] [diff] [review]
reindent file and use string class

Are you re-indenting the whole file, or just that section?
Attachment #218648 - Flags: superreview?(jag)
Attachment #218648 - Flags: superreview+
Attachment #218648 - Flags: review?(jag)
Attachment #218648 - Flags: review+
Comment on attachment 218648 [details] [diff] [review]
reindent file and use string class

mozilla/docshell/shistory/src/nsSHistory.cpp 	1.78
mozilla/docshell/shistory/src/nsSHistory.cpp 	1.79

basically the whole file (except for the pieces that were properly indented)
Attachment #218648 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in before you can comment on or make changes to this bug.